Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,14 @@ class BearerTokenReactiveAuthenticationManagerResolver(
private val client: AuthenticationStoreClient,
private val auditClient: AuthenticationAuditClient,
) : ReactiveAuthenticationManagerResolver<ServerWebExchange> {
override fun resolve(exchange: ServerWebExchange): Mono<ReactiveAuthenticationManager> =
Mono.just(exchange).map {
override fun resolve(exchange: ServerWebExchange): Mono<ReactiveAuthenticationManager> {
val callContextHeader = exchange.request.headers.getFirst("gd-call-context")
if (callContextHeader != null && callContextHeader.contains("\"authMethod\":\"JWT\"")) {
// Gateway has already validated this JWT via call context — skip re-validation
return Mono.just(ReactiveAuthenticationManager { Mono.empty() })
}

return Mono.just(exchange).map {
val sourceIp = exchange.request.remoteAddress?.address?.hostAddress
?: exchange.request.remoteAddress?.hostName

Expand All @@ -51,6 +57,7 @@ class BearerTokenReactiveAuthenticationManagerResolver(
PersistentApiTokenAuthenticationManager(client, auditClient, sourceIp)
)
}
}
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class CallContextAuthenticationProcessor(
val userContextData = UserContextData(
organizationId = authDetails.organizationId,
userId = authDetails.userId,
userName = null,
userName = authDetails.userName,
tokenId = authDetails.tokenId,
authMethod = authMethod,
accessToken = null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,6 @@ data class CallContextAuth(
val organizationId: String,
val userId: String,
val authMethod: String,
val tokenId: String? = null
val tokenId: String? = null,
val userName: String? = null,
)
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,15 @@ internal class BearerTokenReactiveAuthenticationManagerResolverTest {
private val exchange: ServerWebExchange = mockk {
every { request.uri.host } returns HOST
every { request.remoteAddress } returns InetSocketAddress("127.0.0.1", 8080)
every { request.headers.getFirst("gd-call-context") } returns null
}

@Test
fun `authenticates incorrect token type`() {
val mockExchange: ServerWebExchange = mockk {
every { request.uri.host } returns HOST
every { request.remoteAddress } returns InetSocketAddress("127.0.0.1", 8080)
every { request.headers.getFirst("gd-call-context") } returns null
}

val resolver = BearerTokenReactiveAuthenticationManagerResolver(client, auditClient)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
/*
* Copyright 2025 GoodData Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.gooddata.oauth2.server

import io.mockk.every
import io.mockk.mockk
import org.junit.jupiter.api.Test
import org.springframework.security.oauth2.server.resource.BearerTokenAuthenticationToken
import org.springframework.web.server.ServerWebExchange
import strikt.api.expectThat
import strikt.assertions.isNull
import strikt.assertions.isNotNull
import java.net.InetSocketAddress

internal class BearerTokenResolverJwtCallContextTest {

private val client: AuthenticationStoreClient = mockk()
private val auditClient: AuthenticationAuditClient = mockk()

@Test
fun `resolve returns no-op manager when call context has authMethod=JWT`() {
val mockExchange: ServerWebExchange = mockk {
every { request.headers.getFirst("gd-call-context") } returns
"""{"authMethod":"JWT","userId":"u1","orgId":"org1"}"""
every { request.remoteAddress } returns InetSocketAddress("127.0.0.1", 8080)
}

val resolver = BearerTokenReactiveAuthenticationManagerResolver(client, auditClient)
val manager = resolver.resolve(mockExchange).block()!!

val token = BearerTokenAuthenticationToken("some.jwt.token")
val result = manager.authenticate(token).block()

expectThat(result).isNull()
}

@Test
fun `resolve returns non-null manager when call context header is absent`() {
val mockExchange: ServerWebExchange = mockk {
every { request.headers.getFirst("gd-call-context") } returns null
every { request.remoteAddress } returns InetSocketAddress("127.0.0.1", 8080)
}

val resolver = BearerTokenReactiveAuthenticationManagerResolver(client, auditClient)
val manager = resolver.resolve(mockExchange).block()

expectThat(manager).isNotNull()
}

@Test
fun `resolve returns non-null manager when call context has different authMethod`() {
val mockExchange: ServerWebExchange = mockk {
every { request.headers.getFirst("gd-call-context") } returns
"""{"authMethod":"API_TOKEN","userId":"u1","orgId":"org1"}"""
every { request.remoteAddress } returns InetSocketAddress("127.0.0.1", 8080)
}

val resolver = BearerTokenReactiveAuthenticationManagerResolver(client, auditClient)
val manager = resolver.resolve(mockExchange).block()

expectThat(manager).isNotNull()
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,36 @@ class CallContextAuthenticationProcessorTest {
}
}

@Test
fun `propagates userName from CallContextAuth to user context`() {
val authToken = CallContextAuthenticationToken("base64-encoded-header")
val authDetails = CallContextAuth(
organizationId = "org123",
userId = "user456",
authMethod = "OIDC",
tokenId = "token789",
userName = "John Smith"
)

every { headerProcessor.parseCallContextHeader("base64-encoded-header") } returns authDetails
coEvery {
userContextProvider.getContextView(any(), any(), any(), any(), any(), any())
} returns Context.empty()

processor.authenticate(authToken, webExchange, webFilterChain).block()

coVerify(exactly = 1) {
userContextProvider.getContextView(
organizationId = "org123",
userId = "user456",
userName = "John Smith",
tokenId = "token789",
authMethod = AuthMethod.OIDC,
accessToken = null
)
}
}

@Test
fun `null call context throws exception`() {
val authToken = CallContextAuthenticationToken("header-value")
Expand Down