[bot] Merge master/2e8d7d75 into rel/dev#1472
Merged
yenkins-admin merged 3 commits intorel/devfrom Mar 19, 2026
Merged
Conversation
Several issues with the V2 docs pipeline building old release branches: 1. Always use griffe_builder.py and method_page_renderer.py from the current branch instead of checking if they exist on the target branch. The scripts were always executed from the current branch anyway, and griffe does static analysis via --search-path (no imports needed). This removes the json_builder.py fallback that caused ModuleNotFoundError and the pip install -e workaround. 2. Restore Hugo shortcode templates (parameters-block, parameter) that were deleted in the griffe pipeline commit. Old release branches have hand-written method pages using these shortcodes without api_ref frontmatter, so method_page_renderer skips them and Hugo needs the templates to render them. 3. Fix python_ref_builder generating only one page for modules/classes sharing a leaf name (e.g. declarative_model under data_source, workspace, user, permission). The "if name not in links" guard prevented page creation for all but the first. Now all modules and classes always get their pages while the links dict keeps first-wins for type-annotation resolution. 4. Use relative links (href="child_name/") for module child listings and class method/property tables instead of the global links dict. This fixes cross-links where e.g. load_from_disk in CatalogDeclarativeDataSources pointed to workspace's version. 5. Temporarily disable version caching while stabilizing the pipeline. JIRA: trivial risk: nonprod
Re-enable the version docs cache with an updated key that includes docs/layouts/shortcodes/** so shortcode template changes bust the cache. JIRA: trivial risk: nonprod
fix(docs): always use griffe and method_page_renderer
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1472 +/- ##
========================================
Coverage 77.27% 77.27%
========================================
Files 227 227
Lines 14687 14687
========================================
Hits 11350 11350
Misses 3337 3337 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 2e8d7d7 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/23286436440).