Skip to content

fix: Move nullable fields to correct place #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hkad98 merged 1 commit into from
Mar 19, 2026
Merged

fix: Move nullable fields to correct place #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...oddata_sdk/catalog/workspace/declarative_model/workspace/logical_model/dataset/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,6 @@ class CatalogDeclarativeReference(Base):
source_columns: list[str] | None = None
source_column_data_types: list[str] | None = None
sources: list[CatalogDeclarativeReferenceSource] | None = None
is_nullable: bool | None = None
null_value: str | None = None

@staticmethod
def client_class() -> type[DeclarativeReference]:
Expand All @@ -231,6 +229,8 @@ class CatalogDeclarativeReferenceSource(Base):
column: str
target: CatalogGrainIdentifier
data_type: str | None = None
is_nullable: bool | None = None
null_value: str | None = None

@staticmethod
def client_class() -> type[DeclarativeReferenceSource]:
Expand Down
5 changes: 5 additions & 0 deletions ...ata-sdk/tests/catalog/fixtures/data_sources/demo_scan_pdm_and_generate_logical_model.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ interactions:
sources:
- column: campaign_id
dataType: INT
isNullable: true
target:
id: campaign_id
type: attribute
Expand Down Expand Up @@ -321,6 +322,7 @@ interactions:
sources:
- column: campaign_id
dataType: INT
isNullable: true
target:
id: campaign_id
type: attribute
Expand All @@ -331,6 +333,7 @@ interactions:
sources:
- column: customer_id
dataType: INT
isNullable: true
target:
id: customer_id
type: attribute
Expand All @@ -341,6 +344,7 @@ interactions:
sources:
- column: date
dataType: DATE
isNullable: true
target:
id: date
type: date
Expand All @@ -351,6 +355,7 @@ interactions:
sources:
- column: product_id
dataType: INT
isNullable: true
target:
id: product_id
type: attribute
Expand Down
5 changes: 0 additions & 5 deletions .../catalog/fixtures/data_sources/demo_scan_pdm_and_generate_logical_model_sql_datasets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,6 @@ interactions:
sources:
- column: campaign_id
dataType: INT
isNullable: true
target:
id: campaigns.campaign_id
type: attribute
Expand Down Expand Up @@ -670,7 +669,6 @@ interactions:
sources:
- column: campaign_id
dataType: INT
isNullable: true
target:
id: campaigns.campaign_id
type: attribute
Expand All @@ -681,7 +679,6 @@ interactions:
sources:
- column: customer_id
dataType: INT
isNullable: true
target:
id: customers.customer_id
type: attribute
Expand All @@ -692,7 +689,6 @@ interactions:
sources:
- column: date
dataType: DATE
isNullable: true
target:
id: date
type: date
Expand All @@ -703,7 +699,6 @@ interactions:
sources:
- column: product_id
dataType: INT
isNullable: true
target:
id: products.product_id
type: attribute
Expand Down
Loading