feat(gooddata-sdk): [AUTO] add filter_context and date_attribute to search_ai object_types#1468
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add filter_context and date_attribute to search_ai object_types#1468yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…earch_ai object_types docstring Update search_ai() docstring to include the newly added 'filter_context' and 'date_attribute' enum values in object_types parameter, reflecting the LX-2171 OpenAPI spec changes. Add corresponding test for filter_context object type. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1468 +/- ##
=======================================
Coverage 77.27% 77.27%
=======================================
Files 227 227
Lines 14687 14687
=======================================
Hits 11350 11350
Misses 3337 3337 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 'filter_context' and 'date_attribute' to the valid object_types enum values in the search_ai() wrapper docstring, reflecting upstream OpenAPI spec changes in gdc-nas.
P003 | Workflow run
Caution
Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:
packages/gooddata-sdk/tests/compute/fixtures/ai_search_filter_context.yamlWhat changed in gdc-nas
filter_contextas a newObjectTypeenum value in the gen-ai OpenAPI spec alongside existing values.78f7152ConversationResponseListDto,ConversationTurnResponseDto,FeedbackDto,ResponseFeedbackDto,ResponseFeedbackRequest), newGET /api/v1/ai/workspaces/{workspace_id}/chat/conversations/{conversation_id}/responsesendpoint, and breaking change:DELETEconversation now returns 204 (was 200 with body).e58ab04What was implemented in SDK
search_ai()docstring incompute/service.pyto includefilter_contextanddate_attributeas validobject_typesenum values (LX-2171).test_search_ai_filter_context_object_typetest intests/compute/test_compute_service.py.list_conversation_responses()wrapper, new DTOs) could not be implemented becausegooddata-api-clienthas not yet been regenerated with the updated OpenAPI spec. Those changes must be implemented after API client regeneration.Files modified
sdk/packages/gooddata-sdk/src/gooddata_sdk/compute/service.pysdk/packages/gooddata-sdk/tests/compute/test_compute_service.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low