Skip to content

feat(gooddata-sdk): [AUTO] add filter_context and date_attribute to search_ai object_types#1468

Closed
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P003-update-object-types-enum
Closed

feat(gooddata-sdk): [AUTO] add filter_context and date_attribute to search_ai object_types#1468
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P003-update-object-types-enum

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Add 'filter_context' and 'date_attribute' to the valid object_types enum values in the search_ai() wrapper docstring, reflecting upstream OpenAPI spec changes in gdc-nas.

P003 | Workflow run

Caution

Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:

  • packages/gooddata-sdk/tests/compute/fixtures/ai_search_filter_context.yaml

What changed in gdc-nas

  • LX-2171 (PR #21356): Added filter_context as a new ObjectType enum value in the gen-ai OpenAPI spec alongside existing values.
  • GDAI-1448 (PR #21392): Added full response feedback API — new DTOs (ConversationResponseListDto, ConversationTurnResponseDto, FeedbackDto, ResponseFeedbackDto, ResponseFeedbackRequest), new GET /api/v1/ai/workspaces/{workspace_id}/chat/conversations/{conversation_id}/responses endpoint, and breaking change: DELETE conversation now returns 204 (was 200 with body).

What was implemented in SDK

  • Updated search_ai() docstring in compute/service.py to include filter_context and date_attribute as valid object_types enum values (LX-2171).
  • Added test_search_ai_filter_context_object_type test in tests/compute/test_compute_service.py.
  • Note: The GDAI-1448 conversation response feedback endpoints (list_conversation_responses() wrapper, new DTOs) could not be implemented because gooddata-api-client has not yet been regenerated with the updated OpenAPI spec. Those changes must be implemented after API client regeneration.

Files modified

  • sdk/packages/gooddata-sdk/src/gooddata_sdk/compute/service.py
  • sdk/packages/gooddata-sdk/tests/compute/test_compute_service.py

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

…earch_ai object_types docstring

Update search_ai() docstring to include the newly added 'filter_context' and 'date_attribute'
enum values in object_types parameter, reflecting the LX-2171 OpenAPI spec changes. Add
corresponding test for filter_context object type.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.27%. Comparing base (b65ee3f) to head (70fffb4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1468   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files         227      227           
  Lines       14687    14687           
=======================================
  Hits        11350    11350           
  Misses       3337     3337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants