Skip to content

fix(gooddata-dbt): [AUTO] remove GEO_ICON from GoodDataLabelType enum#1467

Closed
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P004-remove-geo-icon-label-type
Closed

fix(gooddata-dbt): [AUTO] remove GEO_ICON from GoodDataLabelType enum#1467
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P004-remove-geo-icon-label-type

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Remove GEO_ICON from the GoodDataLabelType enum in gooddata-dbt as it is no longer a valid valueType in the OpenAPI spec.

Problem: P004 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23239325424

What changed in gdc-nas

  • Commit 81eb97a (merged via PR #21382): Refactored Arrow execution result endpoints in afm-exec-api — replaced two separate Arrow endpoints with a single /binary sub-endpoint. As part of this refactor, GEO_ICON was removed from the OpenAPI valueType enum. Valid values are now: TEXT, HYPERLINK, GEO, GEO_LONGITUDE, GEO_LATITUDE, GEO_AREA, IMAGE.

What was implemented in SDK

  • Removed GEO_ICON = 'GEO_ICON' from the GoodDataLabelType enum in gooddata-dbt to keep it in sync with the updated OpenAPI spec.

Files modified

  • packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

GEO_ICON was removed from the OpenAPI valueType enum in afm-exec-api.
Remove the stale GEO_ICON entry from the LabelType enum to keep the
SDK in sync with the updated API spec.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.27%. Comparing base (b65ee3f) to head (1c4c384).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1467      +/-   ##
==========================================
- Coverage   77.27%   77.27%   -0.01%     
==========================================
  Files         227      227              
  Lines       14687    14686       -1     
==========================================
- Hits        11350    11349       -1     
  Misses       3337     3337              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants