fix(gooddata-dbt): [AUTO] remove GEO_ICON from GoodDataLabelType enum#1467
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
fix(gooddata-dbt): [AUTO] remove GEO_ICON from GoodDataLabelType enum#1467yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
GEO_ICON was removed from the OpenAPI valueType enum in afm-exec-api. Remove the stale GEO_ICON entry from the LabelType enum to keep the SDK in sync with the updated API spec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1467 +/- ##
==========================================
- Coverage 77.27% 77.27% -0.01%
==========================================
Files 227 227
Lines 14687 14686 -1
==========================================
- Hits 11350 11349 -1
Misses 3337 3337 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
GEO_ICONfrom theGoodDataLabelTypeenum in gooddata-dbt as it is no longer a valid valueType in the OpenAPI spec.Problem: P004 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23239325424
What changed in gdc-nas
/binarysub-endpoint. As part of this refactor,GEO_ICONwas removed from the OpenAPIvalueTypeenum. Valid values are now:TEXT,HYPERLINK,GEO,GEO_LONGITUDE,GEO_LATITUDE,GEO_AREA,IMAGE.What was implemented in SDK
GEO_ICON = 'GEO_ICON'from theGoodDataLabelTypeenum ingooddata-dbtto keep it in sync with the updated OpenAPI spec.Files modified
packages/gooddata-dbt/src/gooddata_dbt/dbt/base.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low