feat(gooddata-sdk): [AUTO] add conversation response feedback endpoints#1466
Closed
yenkins-admin wants to merge 2 commits intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add conversation response feedback endpoints#1466yenkins-admin wants to merge 2 commits intomasterfrom
yenkins-admin wants to merge 2 commits intomasterfrom
Conversation
Add get_conversation_responses and set_conversation_response_feedback methods to ComputeService to expose the new GET and PATCH conversation response endpoints from the gen-ai OpenAPI spec (GDAI-1448 / PR #21392). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
get_conversation_responsesandset_conversation_response_feedbackmethods toComputeServiceto expose the new gen-ai conversation response feedback API.Problem: P003 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23238229346
Caution
Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:
packages/gooddata-sdk/tests/compute/fixtures/get_conversation_responses.yamlpackages/gooddata-sdk/tests/compute/fixtures/set_conversation_response_feedback.yamlpackages/gooddata-sdk/tests/compute/fixtures/set_conversation_response_feedback_with_text.yamlWhat changed in gdc-nas
Two commits updated the gen-ai OpenAPI spec:
e58ab04— GDAI-1448 (PR #21392): Adds conversation response feedback API. New GET endpoint to list conversation responses, new PATCH endpoint to submit per-response feedback (POSITIVE/NEGATIVE). New schemas:ConversationResponseListDto,ConversationTurnResponseDto,FeedbackDto,ResponseFeedbackDto,ResponseFeedbackRequest. DELETE conversation endpoint response changed from 200 to 204 no-content.78f7152— LX-2171 (PR #21356): Addsfilter_contextas a new valid value to theObjectTypeenum to support dashboard filter sync in metadata generation.What was implemented in SDK
Added two new methods to
ComputeService:get_conversation_responses(workspace_id, conversation_id)— calls the new GET/api/v1/ai/workspaces/{workspace_id}/chat/conversations/{conversation_id}/responsesendpoint, returnsConversationResponseListDtoset_conversation_response_feedback(workspace_id, conversation_id, response_id, feedback_type, feedback_text=None)— calls the new PATCH endpoint, constructsResponseFeedbackRequestwithResponseFeedbackDto; returnsNone(204 no-content)Three integration test functions with VCR cassettes were added to
test_compute_service.pycovering: GET endpoint, PATCH with POSITIVE feedback, PATCH with NEGATIVE feedback plus text.Files modified
sdk/packages/gooddata-sdk/src/gooddata_sdk/compute/service.pysdk/packages/gooddata-sdk/tests/compute/test_compute_service.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low