Skip to content

feat(gooddata-sdk): [AUTO] add conversation response feedback endpoints#1466

Closed
yenkins-admin wants to merge 2 commits intomasterfrom
feature/auto-P003-conversation-response-feedback
Closed

feat(gooddata-sdk): [AUTO] add conversation response feedback endpoints#1466
yenkins-admin wants to merge 2 commits intomasterfrom
feature/auto-P003-conversation-response-feedback

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Adds get_conversation_responses and set_conversation_response_feedback methods to ComputeService to expose the new gen-ai conversation response feedback API.

Problem: P003 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23238229346

Caution

Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:

  • packages/gooddata-sdk/tests/compute/fixtures/get_conversation_responses.yaml
  • packages/gooddata-sdk/tests/compute/fixtures/set_conversation_response_feedback.yaml
  • packages/gooddata-sdk/tests/compute/fixtures/set_conversation_response_feedback_with_text.yaml

What changed in gdc-nas

Two commits updated the gen-ai OpenAPI spec:

  • e58ab04 — GDAI-1448 (PR #21392): Adds conversation response feedback API. New GET endpoint to list conversation responses, new PATCH endpoint to submit per-response feedback (POSITIVE/NEGATIVE). New schemas: ConversationResponseListDto, ConversationTurnResponseDto, FeedbackDto, ResponseFeedbackDto, ResponseFeedbackRequest. DELETE conversation endpoint response changed from 200 to 204 no-content.
  • 78f7152 — LX-2171 (PR #21356): Adds filter_context as a new valid value to the ObjectType enum to support dashboard filter sync in metadata generation.

What was implemented in SDK

Added two new methods to ComputeService:

  • get_conversation_responses(workspace_id, conversation_id) — calls the new GET /api/v1/ai/workspaces/{workspace_id}/chat/conversations/{conversation_id}/responses endpoint, returns ConversationResponseListDto
  • set_conversation_response_feedback(workspace_id, conversation_id, response_id, feedback_type, feedback_text=None) — calls the new PATCH endpoint, constructs ResponseFeedbackRequest with ResponseFeedbackDto; returns None (204 no-content)

Three integration test functions with VCR cassettes were added to test_compute_service.py covering: GET endpoint, PATCH with POSITIVE feedback, PATCH with NEGATIVE feedback plus text.

Note: New imports (ConversationResponseListDto, ResponseFeedbackDto, ResponseFeedbackRequest) and the actions API methods will resolve only after gooddata-api-client is regenerated from the updated OpenAPI spec.

Files modified

  • sdk/packages/gooddata-sdk/src/gooddata_sdk/compute/service.py
  • sdk/packages/gooddata-sdk/tests/compute/test_compute_service.py

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

Auto Pipeline and others added 2 commits March 18, 2026 09:56
Add get_conversation_responses and set_conversation_response_feedback methods
to ComputeService to expose the new GET and PATCH conversation response endpoints
from the gen-ai OpenAPI spec (GDAI-1448 / PR #21392).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants