feat(gooddata-sdk): [AUTO] expose AutomationAlert with ONCE_PER_INTERVAL trigger in SDK wrapper#1463
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
Conversation
…VAL trigger in SDK wrapper Adds CatalogAutomationAlert class with trigger and interval fields to the SDK wrapper layer, wires it into CatalogDeclarativeAutomation.alert, exports the new class from gooddata_sdk.__init__, and adds unit tests for round-trip serialization. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the new
AutomationAlertmodel in the Python SDK wrapper, addingCatalogAutomationAlertwithtrigger(including newONCE_PER_INTERVALvalue) andinterval(IntervalGranularity: DAY/WEEK/MONTH/QUARTER/YEAR) fields.P008 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23236985423
What changed in gdc-nas
ONCE_PER_INTERVALvalue toAlertTriggerenum inAutomationAlert.ktintervalfield (IntervalGranularityenum: DAY/WEEK/MONTH/QUARTER/YEAR) toAutomationAlertdata classmetadata_sync.proto, added DB migration for new columnWhat was implemented in SDK
CatalogAutomationAlertclass (trigger: str | None,interval: str | None) following the@define(kw_only=True)+client_class()pattern used by existing automation wrapper classesalert: CatalogAutomationAlert | Noneas an optional field onCatalogDeclarativeAutomationwithas_api_model()/from_api_model()converters in both directionsCatalogAutomationAlertfromgooddata_sdk.__init__CatalogAutomationAlertFiles modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/automation.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low