feat(gooddata-sdk): [AUTO] Add CatalogDataSourceAiLakehouse entity model class#1462
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] Add CatalogDataSourceAiLakehouse entity model class#1462yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…del class Add CatalogDataSourceAiLakehouse following the CatalogDataSourceGdStorage pattern (no credentials, empty schema) to represent the new AILAKEHOUSE datasource type. Export the new class from the public __init__.py surface and add unit tests covering instantiation and from_api deserialization.
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Contributor
|
DUPLICATE - CLOSE |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1462 +/- ##
=======================================
Coverage 77.27% 77.28%
=======================================
Files 227 227
Lines 14687 14692 +5
=======================================
+ Hits 11350 11355 +5
Misses 3337 3337 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CatalogDataSourceAiLakehouse entity model class for the new AI Lakehouse datasource type introduced in gdc-nas.
P003 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23236985423
What changed in gdc-nas
AILAKEHOUSE=27toDatabaseTypeproto enum (dbtype.proto) and all OpenAPI specDatabaseTypeenum arrays inmetadata-apiandscan-model. AddedenableAiLakehouseDataSourcefeature flag. AILAKEHOUSE datasource is restricted — cannot be created/deleted via layout or entity APIs; only exposesid/type/name/cacheStrategy/permissionsfields.createDataSourcegRPC RPC toMetadataStoreServiceinmetadata.protowith fullCreateDataSourceRequestmessage (17 fields). The ai-lake provisioner now calls this RPC after successful infrastructure provisioning to register an AILAKEHOUSE datasource.storage_ids(repeated string) field toProvisionDatabaseRequestinai_lake.proto. MovedOperationTypefrom top-level enum to nested enum insideOperationMetadata; renamedUNSPECIFIEDtoOPERATION_TYPE_UNSPECIFIED.What was implemented in SDK
CatalogDataSourceAiLakehouseentity model class following theCatalogDataSourceGdStoragepattern (no credential fields,type='AILAKEHOUSE'), reflecting the backend restriction that AILAKEHOUSE datasources only exposeid/type/name/cacheStrategy/permissions.CatalogDataSourceAiLakehousein the datasource type discriminator mapping sofrom_api()correctly deserializes AILAKEHOUSE API responses.CatalogDataSourceAiLakehousefromgooddata_sdk/__init__.pypublic API surface.from_api()deserialization round-trip.Files modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/entity_model/data_source.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_data_source.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low