feat(gooddata-sdk): [AUTO] add region and data_center fields to CatalogOrganizationAttributes#1461
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
Conversation
…ogOrganizationAttributes Surfaces the new deploymentInfo fields (region, dataCenter) from the Organization API response through the SDK wrapper layer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1461 +/- ##
=======================================
Coverage 77.27% 77.28%
=======================================
Files 227 227
Lines 14687 14689 +2
=======================================
+ Hits 11350 11352 +2
Misses 3337 3337 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
DUPLICATE - CLOSE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose new
regionanddata_centerdeployment info fields in theCatalogOrganizationSDK wrapper to surface the backend'sENABLE_DEPLOYMENT_INFOfeature flag additions.P010 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23236985423
What changed in gdc-nas
regionanddataCenter) to theOrganizationAPI model, gated by theENABLE_DEPLOYMENT_INFOfeature flag.regionmaps togdc.deploymentInfo.clusterNameconfig property;dataCentermaps togdc.deploymentInfo.regionconfig property.feat(metadata-api): add deployment info to APIWhat was implemented in SDK
region: str | None = Nonefield toCatalogOrganizationAttributesdata_center: str | None = Nonefield toCatalogOrganizationAttributesCatalogOrganization.from_api()to readregionanddata_centerfrom the API response attributes (already present in the regenerated API client asOptional[StrictStr]withnullable=True)Files modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/organization.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low