feat(gooddata-sdk): [AUTO] add CatalogAutomationAlert with interval and trigger fields#1460
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add CatalogAutomationAlert with interval and trigger fields#1460yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…nd trigger fields Adds CatalogAutomationAlert wrapper class with AlertTrigger (ALWAYS, ONCE, ONCE_PER_INTERVAL) and IntervalGranularity (DAY, WEEK, MONTH, QUARTER, YEAR) typed fields, plus alert field to CatalogDeclarativeAutomation. Exports new class from the public API surface. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1460 +/- ##
==========================================
+ Coverage 77.27% 77.29% +0.01%
==========================================
Files 227 227
Lines 14687 14704 +17
==========================================
+ Hits 11350 11366 +16
- Misses 3337 3338 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
CatalogAutomationAlertwrapper class to the gooddata-sdk with support for the newONCE_PER_INTERVALtrigger andIntervalGranularity(DAY/WEEK/MONTH/QUARTER/YEAR) fields.Problem: P010 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23235917307
Caution
Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:
packages/gooddata-sdk/tests/catalog/expected/declarative_workspaces.jsonpackages/gooddata-sdk/tests/catalog/expected/declarative_workspaces_snake_case.jsonpackages/gooddata-sdk/tests/catalog/fixtures/workspaces/layout_automations.yamlWhat changed in gdc-nas
ONCE_PER_INTERVALtrigger option toAutomationAlertmodel with newIntervalGranularityenum (DAY, WEEK, MONTH, QUARTER, YEAR). Changes span the Kotlin model, both OpenAPI specs, database schema (new nullableintervalcolumn via Liquibase), and gRPC proto.What was implemented in SDK
CatalogAutomationAlertwrapper class withAlertTrigger(ALWAYS,ONCE,ONCE_PER_INTERVAL) andIntervalGranularity(DAY,WEEK,MONTH,QUARTER,YEAR) typedLiteralaliasesalert: CatalogAutomationAlert | None = Nonefield toCatalogDeclarativeAutomationwith bidirectionalfrom_api_model/as_api_modelconversionCatalogAutomationAlertfromgooddata_sdk.__init__.pyFiles modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/automation.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low