Skip to content

feat(gooddata-sdk): [AUTO] add CatalogDataSourceAiLakehouse data source type#1459

Closed
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P006-add-ailakehouse-data-source-type
Closed

feat(gooddata-sdk): [AUTO] add CatalogDataSourceAiLakehouse data source type#1459
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P006-add-ailakehouse-data-source-type

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

@yenkins-admin yenkins-admin commented Mar 18, 2026

Adds CatalogDataSourceAiLakehouse typed subclass to the gooddata-sdk wrapper, reflecting the new AILAKEHOUSE database type introduced in gdc-nas backend.

P006 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23235917307

What changed in gdc-nas

  • Commit b4e5b11: Adds AILAKEHOUSE as a new database type enum value across OpenAPI specs (metadata-api, sql-executor), proto (dbtype.proto), Kotlin DatabaseType enum, and service layer.
  • Key constraint: the backend introduces maybeRedactAiLakehouse() in OrganizationLayout.kt which strips url, token, schema, and parameters from AI Lakehouse data source declarative serialization — only id, name, type, cacheStrategy, and permissions are preserved.
  • Feature-flagged behind ENABLE_AILAKEHOUSE_DATA_SOURCE.
  • Related Jira tickets: CQ-1987, CQ-1899

What was implemented in SDK

Added CatalogDataSourceAiLakehouse following the CatalogDataSourceGdStorage pattern for data sources that do not expose connection credentials. The class omits url, token, schema, and parameters fields (sets schema='' and uses _NoCredentials) to match the backend's redaction behavior and prevent users from setting credentials that would be silently dropped.

Files modified

  • packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/entity_model/data_source.py — new CatalogDataSourceAiLakehouse class
  • packages/gooddata-sdk/src/gooddata_sdk/__init__.py — export CatalogDataSourceAiLakehouse
  • packages/gooddata-sdk/tests/catalog/test_catalog_data_source.py — unit tests for construction and serialization

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

…ce type

Adds CatalogDataSourceAiLakehouse class following the existing typed
subclass pattern (CatalogDataSourceGdStorage) for data sources that
do not expose connection credentials. The backend strips url, token,
schema, and parameters for AI Lakehouse data sources, so the wrapper
omits those fields by defaulting schema to empty string and using
_NoCredentials. Exports the new class through gooddata_sdk/__init__.py.
Adds unit tests verifying construction and serialization behavior.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.29%. Comparing base (b65ee3f) to head (9e745e7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
+ Coverage   77.27%   77.29%   +0.01%     
==========================================
  Files         227      227              
  Lines       14687    14692       +5     
==========================================
+ Hits        11350    11356       +6     
+ Misses       3337     3336       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants