Skip to content

feat(gooddata-sdk): [AUTO] add filter group title translation support for CB-127#1454

Closed
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P041-filter-group-title-translation
Closed

feat(gooddata-sdk): [AUTO] add filter group title translation support for CB-127#1454
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P041-filter-group-title-translation

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Add extraction and injection of tabs[*].filterGroupsConfig.groups[*].title in the SDK translation workflow to align with the CB-127 backend change.
P041 | https://github.com/gooddata/gdc-nas/actions/runs/23194184862

What changed in gdc-nas

The GoodData backend (commit e8cf816) added $.tabs[*].filterGroupsConfig.groups[*].title to the @LocalizableJson annotation paths on the AnalyticalDashboard.kt content field (merged via PR #20560). This makes filter group titles inside tab-level filterGroupsConfig eligible for backend MD translation. The change is purely additive; no API schema fields were added or removed.

What was implemented in SDK

  • Added _extract_dashboard_filter_group_titles() helper to CatalogWorkspaceService that iterates tabs[*].filterGroupsConfig.groups[*].title and collects non-empty titles for translation.
  • Wired the new helper into get_texts_to_translate() alongside the existing date filter title extraction.
  • Extended set_translated_texts() to write translated values back into filter group titles.
  • Added three unit tests covering extraction, graceful handling of missing tabs, and injection of translated titles.

Files modified

  • packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/service.py
  • packages/gooddata-sdk/tests/catalog/test_catalog_workspace.py

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

… for CB-127

Extend get_texts_to_translate() and set_translated_texts() in CatalogWorkspaceService
to handle $.tabs[*].filterGroupsConfig.groups[*].title — the path made localizable
by the gdc-nas CB-127 backend change. Add _extract_dashboard_filter_group_titles()
helper and unit tests covering extraction and injection of filter group titles.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.24%. Comparing base (4dc3f87) to head (af89098).

Files with missing lines Patch % Lines
...-sdk/src/gooddata_sdk/catalog/workspace/service.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
- Coverage   77.24%   77.24%   -0.01%     
==========================================
  Files         227      227              
  Lines       14672    14682      +10     
==========================================
+ Hits        11334    11341       +7     
- Misses       3338     3341       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants