feat(gooddata-sdk): [AUTO] add filter group title translation support for CB-127#1454
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add filter group title translation support for CB-127#1454yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
… for CB-127 Extend get_texts_to_translate() and set_translated_texts() in CatalogWorkspaceService to handle $.tabs[*].filterGroupsConfig.groups[*].title — the path made localizable by the gdc-nas CB-127 backend change. Add _extract_dashboard_filter_group_titles() helper and unit tests covering extraction and injection of filter group titles. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1454 +/- ##
==========================================
- Coverage 77.24% 77.24% -0.01%
==========================================
Files 227 227
Lines 14672 14682 +10
==========================================
+ Hits 11334 11341 +7
- Misses 3338 3341 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extraction and injection of
tabs[*].filterGroupsConfig.groups[*].titlein the SDK translation workflow to align with the CB-127 backend change.P041 | https://github.com/gooddata/gdc-nas/actions/runs/23194184862
What changed in gdc-nas
The GoodData backend (commit e8cf816) added
$.tabs[*].filterGroupsConfig.groups[*].titleto the@LocalizableJsonannotation paths on theAnalyticalDashboard.ktcontentfield (merged via PR #20560). This makes filter group titles inside tab-levelfilterGroupsConfigeligible for backend MD translation. The change is purely additive; no API schema fields were added or removed.What was implemented in SDK
_extract_dashboard_filter_group_titles()helper toCatalogWorkspaceServicethat iteratestabs[*].filterGroupsConfig.groups[*].titleand collects non-empty titles for translation.get_texts_to_translate()alongside the existing date filter title extraction.set_translated_texts()to write translated values back into filter group titles.Files modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/service.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low