feat(gooddata-sdk): [AUTO] add x_gdc_correlation parameter to get_label_elements()#1453
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add x_gdc_correlation parameter to get_label_elements()#1453yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…el_elements() Adds optional x_gdc_correlation: str | None = None keyword argument to CatalogWorkspaceContentService.get_label_elements() and forwards it to compute_label_elements_post() as a header kwarg for query tagging support (once the API client is regenerated with x-gdc-correlation header support). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1453 +/- ##
=======================================
Coverage 77.24% 77.25%
=======================================
Files 227 227
Lines 14672 14674 +2
=======================================
+ Hits 11334 11336 +2
Misses 3338 3338 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
x_gdc_correlationparameter toCatalogWorkspaceContentService.get_label_elements()to forward thex-gdc-correlationHTTP header to the label elements API endpoint.P038 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
What changed in gdc-nas
Commit dc0729f — feat: enrich label elements with query tags
ElementsController.kt: Added@RequestHeader x-gdc-correlationparameter (CorrelationHeader?) and passes it toElementsProcessor.process()CorrelationHeader.kt: AddedtoExecutionInitiator()method converting header fields toExecutionInitiatorDisplayElementsPreprocessingContext.kt: AddedenableQueryTags: BooleanfieldCalciqueClient.kt:labelElementsInfo()now accepts optionalexecutionInitiatorparameterCalciqueGrpcService.kt: Builds query tags fromexecutionInitiatorwhen present and sets them as a query commentelements-request.proto: AddedExecutionInitiator executionInitiator = 5field toElementsRequestmessageThe backend now accepts
x-gdc-correlationheader onPOST /api/v1/actions/workspaces/{workspaceId}/execution/collect/label/elementsand uses it to embed query tags in SQL for debugging.What was implemented in SDK
x_gdc_correlation: str | None = Nonekeyword parameter toget_label_elements()for backward compatibilityx_gdc_correlationtocompute_label_elements_post()viapaging_paramsdict when the regeneratedgooddata-api-clientexposes the header parametertest_get_label_elements_forwards_x_gdc_correlationverifying the parameter is forwarded correctlyFiles modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/content_service.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace_content.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low