Conversation
Add optional `grand_totals_position` field (Literal enum: pinnedBottom, pinnedTop, bottom, top) to `ExportSettings` to expose the `grandTotalsPosition` setting added in the tabular-exporter OpenAPI spec. Export `GrandTotalsPosition` TypeAlias from the public SDK API surface. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1451 +/- ##
==========================================
+ Coverage 77.24% 77.27% +0.02%
==========================================
Files 227 227
Lines 14672 14686 +14
==========================================
+ Hits 11334 11349 +15
+ Misses 3338 3337 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hkad98
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
grand_totals_positionfield toExportSettingsso SDK users can control grand totals placement when exporting tabular data.Problem: P033 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
What changed in gdc-nas
A new optional
grandTotalsPositionenum field (values:pinnedBottom,pinnedTop,bottom,top) was added to theSettingsobject ofTabularExportRequestin the automation, export-controller, and metadata-api OpenAPI specs. The export-controller was updated to automatically resolve the grand totals position from the visualization object's controls property when the caller does not supply one.36a823e— feat(tabular-exporter): respect grand-total-possition in PDFs in ADWhat was implemented in SDK
Added
GrandTotalsPosition = Literal['pinnedBottom', 'pinnedTop', 'bottom', 'top']TypeAlias andgrand_totals_position: GrandTotalsPosition | None = Nonefield to theExportSettings@defineclass. The field automatically propagates to the API request through the existingBase.to_api()→client_class().from_dict()converter path.GrandTotalsPositionis exported from the publicgooddata_sdkpackage. Parametrized unit tests were added to verify the field value propagates throughto_api()and defaults toNone.Files modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/export/request.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/export/test_export_service.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low