feat(gooddata-sdk): [AUTO] add GEO_ICON to GoodDataLabelType enum#1450
Merged
feat(gooddata-sdk): [AUTO] add GEO_ICON to GoodDataLabelType enum#1450
Conversation
Adds GEO_ICON = 'GEO_ICON' to the GoodDataLabelType enum in gooddata-dbt, matching the new GEO_ICON label type added to CommonModel.kt in gdc-nas. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1450 +/- ##
=======================================
Coverage 77.24% 77.25%
=======================================
Files 227 227
Lines 14672 14673 +1
=======================================
+ Hits 11334 11335 +1
Misses 3338 3338 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hkad98
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GEO_ICON to the GoodDataLabelType enum in gooddata-dbt to support the new label type introduced in gdc-nas.
Problem ID: P031 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
What changed in gdc-nas
GEO_ICONas a new enum value toLabelTypeacrossCommonModel.kt,execution-data-contracts, proto files (GEO_ICON=8), gRPC extension mappings, and OpenAPI specs forafm-exec-apiandmetadata-api.What was implemented in SDK
Added
GEO_ICON = 'GEO_ICON'to theGoodDataLabelTypeenum ingooddata-dbt/dbt/base.py, positioned afterGEO_AREAto match the ordering inCommonModel.kt. This is the only SDK wrapper change required — all other SDK layers (gooddata-sdkCatalogDeclarativeLabel,CatalogLabel,CatalogFilterBy,gooddata-flexconnect) use plainstr | Nonefor label types and need no updates.Files modified
sdk/packages/gooddata-dbt/src/gooddata_dbt/dbt/base.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low