Skip to content

feat(gooddata-sdk): [AUTO] add GEO_ICON to GoodDataLabelType enum#1450

Merged
hkad98 merged 1 commit intomasterfrom
feature/auto-P031-add-geo-icon-label-type
Mar 17, 2026
Merged

feat(gooddata-sdk): [AUTO] add GEO_ICON to GoodDataLabelType enum#1450
hkad98 merged 1 commit intomasterfrom
feature/auto-P031-add-geo-icon-label-type

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Adds GEO_ICON to the GoodDataLabelType enum in gooddata-dbt to support the new label type introduced in gdc-nas.

Problem ID: P031 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862

What changed in gdc-nas

  • f9a6963: Adds GEO_ICON as a new enum value to LabelType across CommonModel.kt, execution-data-contracts, proto files (GEO_ICON=8), gRPC extension mappings, and OpenAPI specs for afm-exec-api and metadata-api.

What was implemented in SDK

Added GEO_ICON = 'GEO_ICON' to the GoodDataLabelType enum in gooddata-dbt/dbt/base.py, positioned after GEO_AREA to match the ordering in CommonModel.kt. This is the only SDK wrapper change required — all other SDK layers (gooddata-sdk CatalogDeclarativeLabel, CatalogLabel, CatalogFilterBy, gooddata-flexconnect) use plain str | None for label types and need no updates.

Files modified

  • sdk/packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

Adds GEO_ICON = 'GEO_ICON' to the GoodDataLabelType enum in gooddata-dbt,
matching the new GEO_ICON label type added to CommonModel.kt in gdc-nas.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.25%. Comparing base (4dc3f87) to head (d609896).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1450   +/-   ##
=======================================
  Coverage   77.24%   77.25%           
=======================================
  Files         227      227           
  Lines       14672    14673    +1     
=======================================
+ Hits        11334    11335    +1     
  Misses       3338     3338           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 merged commit 15b4033 into master Mar 17, 2026
12 checks passed
@hkad98 hkad98 deleted the feature/auto-P031-add-geo-icon-label-type branch March 17, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants