feat(gooddata-sdk): [AUTO] add certification and graph entity types to SDK wrappers#1448
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add certification and graph entity types to SDK wrappers#1448yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…K wrappers - Add 'relation' field to CatalogDependentEntitiesRequest for DEPENDENTS/DEPENDENCIES graph traversal direction - Add certification fields (certification, certification_message, certified_at, certified_by) to CatalogDeclarativeAnalyticalDashboard, CatalogDeclarativeMetric, CatalogDeclarativeVisualizationObject - Add set_certification() service method to CatalogWorkspaceContentService - Add unit tests for new relation field and set_certification method Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1448 +/- ##
==========================================
+ Coverage 77.24% 77.28% +0.03%
==========================================
Files 227 227
Lines 14672 14694 +22
==========================================
+ Hits 11334 11356 +22
Misses 3338 3338 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add certification fields, setCertification endpoint wrapper, and graph relation direction support to gooddata-sdk.
P027 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
Caution
Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:
packages/gooddata-sdk/tests/catalog/fixtures/workspace_content/demo_get_dependent_entities_graph_from_entry_points_with_relation.yamlWhat changed in gdc-nas
feat(metadata-api): add certification for analytics entities (GDAI-1381)— newPOST /api/v1/actions/workspaces/{workspaceId}/setCertificationendpoint; certification fields (certification,certificationMessage,certifiedAt,certifiedBy) added toAnalyticalDashboard,Metric,VisualizationObjectand their declarative variants.feat(metadata-api): add certification setting (GDAI-1381)— newCERTIFY_PARENT_OBJECTSSettingTypeadded to all setting type enum arrays across OpenAPI spec.feat(metadata-api): add direction parameter to dependent entities graph (GDAI-1395)— newEntityRelationenum (DEPENDENTS/DEPENDENCIES) onDependentEntitiesRequest; defaults toDEPENDENTS(backward compatible).What was implemented in SDK
relation: str | None = Nonefield toCatalogDependentEntitiesRequestenablingDEPENDENTS/DEPENDENCIESgraph traversal direction; passed through to API call.set_certification()service method toCatalogWorkspaceContentServicewrapping the newPOST .../setCertificationendpoint via_actions_api.relationparameter toget_dependent_entities_graph_from_entry_points()for backward-compatible graph direction control.certification,certification_message,certified_at,certified_by) toCatalogDeclarativeAnalyticalDashboard,CatalogDeclarativeMetric, andCatalogDeclarativeVisualizationObjectdeclarative wrapper classes.set_certificationparameter forwarding.Files modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/entity_model/graph_objects/graph.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/analytics_model/analytics_model.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/content_service.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace_content.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low