Skip to content

feat(gooddata-sdk): [AUTO] add certification and graph entity types to SDK wrappers#1448

Closed
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P027-certification-graph-relation
Closed

feat(gooddata-sdk): [AUTO] add certification and graph entity types to SDK wrappers#1448
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P027-certification-graph-relation

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Add certification fields, setCertification endpoint wrapper, and graph relation direction support to gooddata-sdk.

P027 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862

Caution

Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:

  • packages/gooddata-sdk/tests/catalog/fixtures/workspace_content/demo_get_dependent_entities_graph_from_entry_points_with_relation.yaml

What changed in gdc-nas

  • 0c3c662 feat(metadata-api): add certification for analytics entities (GDAI-1381) — new POST /api/v1/actions/workspaces/{workspaceId}/setCertification endpoint; certification fields (certification, certificationMessage, certifiedAt, certifiedBy) added to AnalyticalDashboard, Metric, VisualizationObject and their declarative variants.
  • a6f9082 feat(metadata-api): add certification setting (GDAI-1381) — new CERTIFY_PARENT_OBJECTS SettingType added to all setting type enum arrays across OpenAPI spec.
  • 7454c9c feat(metadata-api): add direction parameter to dependent entities graph (GDAI-1395) — new EntityRelation enum (DEPENDENTS/DEPENDENCIES) on DependentEntitiesRequest; defaults to DEPENDENTS (backward compatible).

What was implemented in SDK

  • Added relation: str | None = None field to CatalogDependentEntitiesRequest enabling DEPENDENTS/DEPENDENCIES graph traversal direction; passed through to API call.
  • Added set_certification() service method to CatalogWorkspaceContentService wrapping the new POST .../setCertification endpoint via _actions_api.
  • Added relation parameter to get_dependent_entities_graph_from_entry_points() for backward-compatible graph direction control.
  • Added certification fields (certification, certification_message, certified_at, certified_by) to CatalogDeclarativeAnalyticalDashboard, CatalogDeclarativeMetric, and CatalogDeclarativeVisualizationObject declarative wrapper classes.
  • Added unit tests for relation field serialization and set_certification parameter forwarding.

Files modified

  • packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/entity_model/graph_objects/graph.py
  • packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/analytics_model/analytics_model.py
  • packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/content_service.py
  • packages/gooddata-sdk/tests/catalog/test_catalog_workspace_content.py

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

…K wrappers

- Add 'relation' field to CatalogDependentEntitiesRequest for DEPENDENTS/DEPENDENCIES graph traversal direction
- Add certification fields (certification, certification_message, certified_at, certified_by) to CatalogDeclarativeAnalyticalDashboard, CatalogDeclarativeMetric, CatalogDeclarativeVisualizationObject
- Add set_certification() service method to CatalogWorkspaceContentService
- Add unit tests for new relation field and set_certification method

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.28%. Comparing base (4dc3f87) to head (e9e3892).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   77.24%   77.28%   +0.03%     
==========================================
  Files         227      227              
  Lines       14672    14694      +22     
==========================================
+ Hits        11334    11356      +22     
  Misses       3338     3338              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants