feat(gooddata-sdk): [AUTO] add CatalogSmartFunctionsService with get_trending_objects for GDAI-1418#1447
Closed
yenkins-admin wants to merge 2 commits intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add CatalogSmartFunctionsService with get_trending_objects for GDAI-1418#1447yenkins-admin wants to merge 2 commits intomasterfrom
yenkins-admin wants to merge 2 commits intomasterfrom
Conversation
…trending_objects for GDAI-1418
Wraps the new GET /api/v1/actions/workspaces/{workspaceId}/ai/analyticsCatalog/trendingObjects
endpoint (already present in gooddata-api-client) by adding CatalogTrendingObjectItem and
CatalogTrendingObjectsResult model classes, CatalogSmartFunctionsService, and exposing them
through the GoodDataSdk facade and public __init__ exports.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SDK wrapper for the new Tredimark AI trendingObjects endpoint (GDAI-1418), exposing
get_trending_objectsviaGoodDataSdk.catalog_smart_functions.Problem: P014 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
Caution
Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:
packages/gooddata-sdk/tests/catalog/smart_functions/fixtures/test_get_trending_objects.yamlWhat changed in gdc-nas
GET /api/v1/actions/workspaces/{workspaceId}/ai/analyticsCatalog/trendingObjectsendpoint toafm-exec-apireturningTrendingObjectItemandTrendingObjectsResultmodelsTrendingObject,TrendingObjectsRequest,TrendingObjectsResponseandtrending_objectsrpc added toGenAIServicegen-aiPython microserviceWhat was implemented in SDK
CatalogTrendingObjectItemandCatalogTrendingObjectsResultwrapper model classes (using@attrs.define(kw_only=True)) withfrom_api_model()class methodsCatalogSmartFunctionsServicewith aget_trending_objects(workspace_id)method callingSmartFunctionsApi.trending_objects()SmartFunctionsApivia a newsmart_functions_apiproperty onGoodDataApiClientCatalogSmartFunctionsServiceintoGoodDataSdkascatalog_smart_functionsgooddata_sdk/__init__.pyFiles modified
packages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/src/gooddata_sdk/client.pypackages/gooddata-sdk/src/gooddata_sdk/sdk.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/analytics_catalog/__init__.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/analytics_catalog/model/__init__.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/analytics_catalog/model/trending_objects.py(new)packages/gooddata-sdk/src/gooddata_sdk/catalog/smart_functions/__init__.py(new)packages/gooddata-sdk/src/gooddata_sdk/catalog/smart_functions/service.py(new)packages/gooddata-sdk/tests/catalog/smart_functions/__init__.py(new)packages/gooddata-sdk/tests/catalog/smart_functions/test_trending_objects.py(new)JIRA: PENDING (Jira ticket will be created after review)
Risk: Low