Conversation
…nullable CatalogLlmProviderAttributes.models and .provider_config are now Optional (| None = None) to match the updated OpenAPI spec where providerConfig and models are no longer required fields. from_api() now sets both to None (instead of empty list/dict) when the API returns null, preventing incorrect construction of default objects. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1446 +/- ##
=======================================
Coverage 77.24% 77.24%
=======================================
Files 227 227
Lines 14672 14672
=======================================
Hits 11334 11334
Misses 3338 3338 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hkad98
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
CatalogLlmProviderAttributes.modelsand.provider_configoptional to match the updated metadata-api OpenAPI spec where both fields are no longer required.P020 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
What changed in gdc-nas
abb5c41— Regenerated OpenAPI spec:providerConfiggainsnullable: trueandmodels/providerConfigremoved fromrequiredarrays inJsonApiLlmProviderIn,JsonApiLlmProviderInPatch, andJsonApiLlmProviderOutschemas06ec721—LlmProvider.providerConfigandLlmProvider.modelschanged from required non-nullable fields to nullable optional (defaultnull) to fix a PATCH 500 error caused by the stock framework attempting to reflectively construct a sealed class via private constructorRelated Jira: GDAI-1350
What was implemented in SDK
CatalogLlmProviderAttributes.models:List[CatalogLlmProviderModel]→List[CatalogLlmProviderModel] | None = NoneCatalogLlmProviderAttributes.provider_config:CatalogLlmProviderConfig→CatalogLlmProviderConfig | None = NoneCatalogLlmProvider.from_api(): fixed null-safety — returnsNoneformodelsandprovider_configwhen the API response containsnull, instead of constructingCatalogLlmProviderConfigfrom an empty dict or iterating overNoneCatalogLlmProviderAttributeswith the already-correctCatalogLlmProviderPatchAttributespatternFiles modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low