feat(gooddata-sdk): [AUTO] add CatalogKnowledgeService wrapper for knowledge API endpoints#1444
Closed
yenkins-admin wants to merge 2 commits intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add CatalogKnowledgeService wrapper for knowledge API endpoints#1444yenkins-admin wants to merge 2 commits intomasterfrom
yenkins-admin wants to merge 2 commits intomasterfrom
Conversation
…owledge API endpoints Implements SDK wrapper layer for the 7 knowledge endpoints exposed by the afm-exec-api OpenAPI spec (LX-2106): create, upsert, list, get, delete, patch documents and search knowledge. Adds 11 Catalog* model classes, CatalogKnowledgeService, GoodDataSdk.catalog_knowledge property, and public exports in __init__.py. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CatalogKnowledgeService with 7 knowledge endpoint methods (create, upsert, list, get, delete, patch document; search knowledge) and 11 Catalog* wrapper models to gooddata-sdk, exposing the knowledge CRUD and search endpoints unhidden in afm-exec-api (LX-2106).
Problem ID: P011 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
Caution
Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:
packages/gooddata-sdk/tests/catalog/knowledge/fixtures/test_list_documents.yamlpackages/gooddata-sdk/tests/catalog/knowledge/fixtures/test_search_knowledge.yamlpackages/gooddata-sdk/tests/catalog/knowledge/fixtures/test_create_document.yamlpackages/gooddata-sdk/tests/catalog/knowledge/fixtures/test_upsert_document.yamlpackages/gooddata-sdk/tests/catalog/knowledge/fixtures/test_get_document.yamlpackages/gooddata-sdk/tests/catalog/knowledge/fixtures/test_patch_document.yamlpackages/gooddata-sdk/tests/catalog/knowledge/fixtures/test_delete_document.yamlWhat changed in gdc-nas
ENABLE_AI_KNOWLEDGEenum toFeatureFlag.kt,enable_ai_knowledgefield to PythonFeatureFlagsmodel, and deployment config entriescheckGenAIChatFeatureFlag()withcheckAIKnowledgeFeatureFlag()inKnowledgeController.ktfor all 7 endpoints@Operation(hidden = true)from 7 endpoints and adds 10 new schemas + 3 new paths toopen-api-spec.jsonWhat was implemented in SDK
Created a full SDK wrapper layer for the knowledge domain:
CatalogKnowledgeService(CatalogServiceBase)with methods:create_document,upsert_document,list_documents,get_document,delete_document,patch_document,search_knowledge@attrs.definewrapper model classes (8 response DTOs + 3 request DTOs withas_api_model())GoodDataSdk.catalog_knowledgeproperty registered on the SDK entry pointgooddata_sdk.__init__.pyFiles modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/knowledge/entity_model/knowledge.py(new)packages/gooddata-sdk/src/gooddata_sdk/catalog/knowledge/entity_model/__init__.py(new)packages/gooddata-sdk/src/gooddata_sdk/catalog/knowledge/__init__.py(new)packages/gooddata-sdk/src/gooddata_sdk/catalog/knowledge/service.py(new)packages/gooddata-sdk/src/gooddata_sdk/sdk.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/knowledge/__init__.py(new)packages/gooddata-sdk/tests/catalog/knowledge/test_catalog_knowledge.py(new)JIRA: PENDING (Jira ticket will be created after review)
Risk: Low