feat(gooddata-sdk): [AUTO] add enable_hybrid_search param to search_ai()#1443
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add enable_hybrid_search param to search_ai()#1443yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
Expose the `enable_hybrid_search` boolean parameter in the `search_ai()` wrapper method so SDK users can opt into hybrid search (vector + keyword RRF fusion). The underlying SearchRequest API model already supports the field after the GDAI-1349 regeneration; only the wrapper signature and test call were missing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1443 +/- ##
==========================================
- Coverage 77.24% 77.23% -0.02%
==========================================
Files 227 227
Lines 14672 14674 +2
==========================================
Hits 11334 11334
- Misses 3338 3340 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
enable_hybrid_searchparameter to thesearch_ai()SDK wrapper method, surfacing the hybrid search capability introduced by GDAI-1349 in the gdc-nas backend.P016 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
Caution
Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:
packages/gooddata-sdk/tests/compute/fixtures/ai_search.yamlpackages/gooddata-sdk/tests/compute/fixtures/ai_search_full_params.yamlWhat changed in gdc-nas
Commit 64b778a (merged via PR #20454) added
enableHybridSearch(boolean, defaultfalse) to theSearchRequestmodel across:afm-exec-apiOpenAPI spec (open-api-spec.json)Search.kt) and processor (GenAIProcessor.kt)gen_ai.proto— fieldenable_hybrid_search = 16)search_service.py,object_repository.py,qdrant_object_repository.py)When enabled, the feature uses Qdrant Prefetch + FusionQuery (RRF) combining substring match on
titleand vector embedding search instead of pure vector search.The
gooddata-api-clientwas already regenerated and bothmodel/search_request.pyandmodels/search_request.pyalready exposeenable_hybrid_search: Optional[StrictBool] = Field(default=False, alias='enableHybridSearch').What was implemented in SDK
Added
enable_hybrid_search: bool | None = Noneto thesearch_ai()method signature incompute/service.py, following the same conditional-kwargs pattern used by other optional parameters (deep_search,limit, etc.). Updated the full-params integration test to passenable_hybrid_search=True.Files modified
packages/gooddata-sdk/src/gooddata_sdk/compute/service.pypackages/gooddata-sdk/tests/compute/test_compute_service.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low