Skip to content

feat(gooddata-sdk): [AUTO] add MatchAttributeFilter SDK wrapper for LX-2032#1440

Closed
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P007-match-attribute-filter
Closed

feat(gooddata-sdk): [AUTO] add MatchAttributeFilter SDK wrapper for LX-2032#1440
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P007-match-attribute-filter

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Add MatchAttributeFilter SDK wrapper class and deserialization support for new AFM attribute filter type introduced in LX-2032.

P007 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862

What changed in gdc-nas

Three commits extended AFM filter data contracts with new filter types and fields:

  • MatchAttributeFilter — new attribute filter type with STARTS_WITH/ENDS_WITH/CONTAINS pattern matching and case sensitivity control (commit 2f4fd78)
  • AllTimeDateFilter — new filter type with EmptyValueHandling enum (INCLUDE/EXCLUDE/ONLY) (commit 4930f8c)
  • AbsoluteDateFilter / RelativeDateFilter — new optional emptyValueHandling field (default EXCLUDE) (commit 2c1fe47)

All 4 OpenAPI specs (afm-exec-api, automation, export-controller, metadata-api) and proto files updated. API client already regenerated with new models.

What was implemented in SDK

AllTimeDateFilter and emptyValueHandling on AbsoluteDateFilter/RelativeDateFilter were already present. The missing piece was MatchAttributeFilter:

  • Added AttributeFilterMatchType TypeAlias and MatchAttributeFilter class with label, literal, match_type, negate, case_sensitive, local_identifier, apply_on_result fields and as_api_model() serialization
  • Added matchAttributeFilter deserialization branch in ComputeToSdkConverter.convert_filter()
  • Exported MatchAttributeFilter and AttributeFilterMatchType from gooddata_sdk.__init__
  • Added unit tests for construction, serialization, and converter deserialization

Files modified

  • packages/gooddata-sdk/src/gooddata_sdk/compute/model/filter.py
  • packages/gooddata-sdk/src/gooddata_sdk/compute/compute_to_sdk_converter.py
  • packages/gooddata-sdk/src/gooddata_sdk/__init__.py
  • packages/gooddata-sdk/tests/compute_model/test_attribute_filters.py
  • packages/gooddata-sdk/tests/compute/test_compute_to_sdk_converter.py

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

…X-2032

Add MatchAttributeFilter class to compute/model/filter.py with label,
literal, match_type (STARTS_WITH/ENDS_WITH/CONTAINS), negate, case_sensitive
fields and as_api_model() serialization. Add matchAttributeFilter
deserialization branch in ComputeToSdkConverter.convert_filter(). Export
MatchAttributeFilter and AttributeFilterMatchType from public API.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.29%. Comparing base (4dc3f87) to head (0f65253).

Files with missing lines Patch % Lines
...ddata-sdk/src/gooddata_sdk/compute/model/filter.py 90.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1440      +/-   ##
==========================================
+ Coverage   77.24%   77.29%   +0.04%     
==========================================
  Files         227      227              
  Lines       14672    14725      +53     
==========================================
+ Hits        11334    11382      +48     
- Misses       3338     3343       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants