feat(gooddata-sdk): [AUTO] add MatchAttributeFilter SDK wrapper for LX-2032#1440
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add MatchAttributeFilter SDK wrapper for LX-2032#1440yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…X-2032 Add MatchAttributeFilter class to compute/model/filter.py with label, literal, match_type (STARTS_WITH/ENDS_WITH/CONTAINS), negate, case_sensitive fields and as_api_model() serialization. Add matchAttributeFilter deserialization branch in ComputeToSdkConverter.convert_filter(). Export MatchAttributeFilter and AttributeFilterMatchType from public API. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1440 +/- ##
==========================================
+ Coverage 77.24% 77.29% +0.04%
==========================================
Files 227 227
Lines 14672 14725 +53
==========================================
+ Hits 11334 11382 +48
- Misses 3338 3343 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MatchAttributeFilter SDK wrapper class and deserialization support for new AFM attribute filter type introduced in LX-2032.
P007 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
What changed in gdc-nas
Three commits extended AFM filter data contracts with new filter types and fields:
STARTS_WITH/ENDS_WITH/CONTAINSpattern matching and case sensitivity control (commit 2f4fd78)EmptyValueHandlingenum (INCLUDE/EXCLUDE/ONLY) (commit 4930f8c)emptyValueHandlingfield (defaultEXCLUDE) (commit 2c1fe47)All 4 OpenAPI specs (afm-exec-api, automation, export-controller, metadata-api) and proto files updated. API client already regenerated with new models.
What was implemented in SDK
AllTimeDateFilterandemptyValueHandlingonAbsoluteDateFilter/RelativeDateFilterwere already present. The missing piece wasMatchAttributeFilter:AttributeFilterMatchTypeTypeAlias andMatchAttributeFilterclass withlabel,literal,match_type,negate,case_sensitive,local_identifier,apply_on_resultfields andas_api_model()serializationmatchAttributeFilterdeserialization branch inComputeToSdkConverter.convert_filter()MatchAttributeFilterandAttributeFilterMatchTypefromgooddata_sdk.__init__Files modified
packages/gooddata-sdk/src/gooddata_sdk/compute/model/filter.pypackages/gooddata-sdk/src/gooddata_sdk/compute/compute_to_sdk_converter.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute_model/test_attribute_filters.pypackages/gooddata-sdk/tests/compute/test_compute_to_sdk_converter.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low