feat(gooddata-sdk): [AUTO] add Arrow binary result endpoint support (retrieveResultBinary)#1439
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add Arrow binary result endpoint support (retrieveResultBinary)#1439yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…I format support
Expose the new BETA retrieveResultBinary endpoint (GET /result/{resultId}/binary)
through BareExecutionResponse and Execution wrapper classes. The method accepts an
optional cancel token but deliberately omits paging parameters (offset/limit/
excludedTotalDimensions) which are not supported on the binary endpoint.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1439 +/- ##
=======================================
Coverage 77.24% 77.25%
=======================================
Files 227 227
Lines 14672 14681 +9
=======================================
+ Hits 11334 11342 +8
- Misses 3338 3339 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the new BETA Apache Arrow binary result endpoint (
retrieveResultBinary) through the gooddata-sdk wrapper by adding aread_result_binary()method toBareExecutionResponseandExecution.Problem: P003 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23194184862
What changed in gdc-nas
Two PRs added Arrow binary format support to the afm-exec-api execute-result endpoint:
application/vnd.apache.arrow.file,application/vnd.apache.arrow.stream) to the existing/result/{resultId}endpoint.GET /result/{resultId}/binaryendpoint (operationId: retrieveResultBinary, marked BETA). The original endpoint now returns JSON only. The binary endpoint has no paging parameters (offset/limit/excludedTotalDimensions).The gooddata-api-client was already regenerated with
retrieve_result_binaryincomputation_api.pyandactions_api.py.What was implemented in SDK
read_result_binary(workspace_id, result_id, x_gdc_cancel_token=None)method toBareExecutionResponseandExecutionclasses, callingretrieve_result_binaryvia_actions_api. The method explicitly omits paging parameters, matching the binary endpoint's API contract.test_execution_binary.pyverifying correct parameter forwarding and absence of paging parameters.Files modified
packages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/tests/compute/test_execution_binary.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low