Skip to content

feat(gooddata-sdk): [AUTO] add gen-ai conversation HTTP API wrapper#1427

Closed
yenkins-admin wants to merge 2 commits intomasterfrom
feature/auto-P006-gen-ai-conversation-api
Closed

feat(gooddata-sdk): [AUTO] add gen-ai conversation HTTP API wrapper#1427
yenkins-admin wants to merge 2 commits intomasterfrom
feature/auto-P006-gen-ai-conversation-api

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

@yenkins-admin yenkins-admin commented Mar 16, 2026

Add SDK wrapper layer for the new gen-ai conversation HTTP API introduced by GDAI-1452, GDAI-1449, and GDAI-1448.

Problem ID: P006 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23137028021

What changed in gdc-nas

  • GDAI-1452 (c75abfe): Created microservices/gen-ai/src/test/resources/openapi/open-api-spec.json (1483 lines) establishing all gen-ai HTTP API endpoints: POST/GET /conversations, DELETE/GET /conversations/{id}, GET /conversations/{id}/items, POST /conversations/{id}/messages. Added docker-compose, nginx/apidocs, and helm template references.
  • GDAI-1449 (55cbf42): Added AllowedRelationshipTypeDto, ObjectType enum (11 values), SendMessageOptionsDto, and SendMessageSearchOptionsDto schemas. Updated SendMessageRequest to include optional options field.
  • GDAI-1448 (e58ab04): Added response feedback functionality with GET /conversations/{id}/responses and PATCH /conversations/{id}/responses/{response_id} endpoints. Added FeedbackDto, ConversationTurnResponseDto, ResponseFeedbackDto schemas. Changed DELETE conversation response code from 200 to 204.

What was implemented in SDK

Created a new gen_ai package under catalog/workspace/ with:

  • CatalogGenAiService: direct HTTP service wrapping all conversation endpoints (list/create/get/delete conversations, list items, send message with options, list responses, update feedback)
  • Catalog model classes: CatalogConversation, CatalogConversationItem, CatalogConversationTurnResponse, CatalogConversationFeedback, CatalogSendMessageOptions, CatalogSendMessageSearchOptions, CatalogGenAiAllowedRelationshipType
  • ObjectTypeAlias TypeAlias covering all 11 gen-ai object types
  • Service registered on GoodDataSdk as catalog_gen_ai
  • All new classes exported from gooddata_sdk.__init__
  • Unit tests covering model serialization round-trips for all new classes

Files modified

  • packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/gen_ai/__init__.py (new)
  • packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/gen_ai/conversation.py (new)
  • packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/gen_ai/service.py (new)
  • packages/gooddata-sdk/src/gooddata_sdk/__init__.py
  • packages/gooddata-sdk/src/gooddata_sdk/sdk.py
  • packages/gooddata-sdk/tests/gen_ai/__init__.py (new)
  • packages/gooddata-sdk/tests/gen_ai/test_gen_ai_models.py (new)

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

Auto Implementation and others added 2 commits March 16, 2026 09:59
…P006)

Introduces CatalogGenAiService and supporting catalog model classes wrapping
the new gen-ai conversation HTTP API endpoints from GDAI-1452, GDAI-1449, and
GDAI-1448: conversation CRUD, send-message with search options, and response
feedback (GET/PATCH). Exports all new public classes from gooddata_sdk.__init__
and registers CatalogGenAiService on GoodDataSdk as catalog_gen_ai property.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 69.85646% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.25%. Comparing base (b95ca11) to head (ded47f1).

Files with missing lines Patch % Lines
...c/gooddata_sdk/catalog/workspace/gen_ai/service.py 36.08% 62 Missing ⚠️
packages/gooddata-sdk/src/gooddata_sdk/sdk.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
- Coverage   77.36%   77.25%   -0.11%     
==========================================
  Files         228      230       +2     
  Lines       14775    14984     +209     
==========================================
+ Hits        11430    11576     +146     
- Misses       3345     3408      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants