feat(gooddata-sdk): [AUTO] deprecate LlmEndpoint, add ResolvedLlmProvider wrappers and resolveLlmProviders#1425
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
Conversation
…ider wrappers and resolveLlmProviders - Make default_model_id required (non-nullable) in CatalogLlmProviderAttributes to match backend constraint - Add CatalogResolvedLlm, CatalogResolvedLlmProvider, CatalogResolvedLlms wrappers for the new resolveLlmProviders endpoint - Add resolve_llm_providers(workspace_id) service method on CatalogOrganizationService - Export new classes from gooddata_sdk.__init__ - Add test_resolve_llm_providers integration test (cassette to be recorded) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate gooddata-sdk to reflect gdc-nas LlmEndpoint deprecation: make
default_model_idmandatory onCatalogLlmProviderAttributes, addCatalogResolvedLlm*wrapper classes, and expose a newresolve_llm_providers()service method.Problem: P002 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23137028021
Caution
Test fixtures need recording. The following fixture files are referenced by tests but do not exist yet.
They must be recorded against a live GoodData server before merging:
packages/gooddata-sdk/tests/catalog/fixtures/organization/resolve_llm_providers.yamlWhat changed in gdc-nas
A multi-phase migration deprecated
LlmEndpointin favor ofLlmProvideracrossafm-exec-apiandmetadata-api:LlmEndpoint/LlmProviderbehind feature flagENABLE_LLM_ENDPOINT_REPLACEMENT; refactorAIControllerfor active LLM resolutionLlmEndpointmodel and all five metadata-api CRUD operations + three afm-exec-api action endpoints asdeprecatedin OpenAPI specsGET /api/v1/actions/workspaces/{workspaceId}/ai/resolveLlmProvidersendpoint with newResolvedLlm,ResolvedLlmProvider, andResolvedLlmsmodelsdefaultModelIdmandatory (non-nullable) onLlmProvider; throwsBadRequestExceptionif null on create or PATCHWhat was implemented in SDK
default_model_idmandatory (str, notstr | None) inCatalogLlmProviderAttributesto match the backend constraint that now throwsBadRequestExceptionfor null valuesCatalogResolvedLlm,CatalogResolvedLlmProvider, andCatalogResolvedLlmswrapper classes in a newresolved_llm_provider.pymoduleresolve_llm_providers(workspace_id)service method onCatalogOrganizationServicegooddata_sdk.__init__test_resolve_llm_providersintegration test (cassette must be recorded once API client is regenerated with the new endpoint)Files modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/resolved_llm_provider.py(new)packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_organization.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low