feat(gooddata-sdk): [AUTO] add grand_totals_position to ExportSettings#1424
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add grand_totals_position to ExportSettings#1424yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
Added GrandTotalsPosition TypeAlias and grand_totals_position field to ExportSettings to expose the new grandTotalsPosition API field introduced in TabularExportRequest.Settings for controlling PDF grand total placement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
+ Coverage 77.36% 77.38% +0.02%
==========================================
Files 228 228
Lines 14775 14789 +14
==========================================
+ Hits 11430 11444 +14
Misses 3345 3345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
grand_totals_positionfield toExportSettingsto support controlling grand total placement in PDF exports from Analytical Designer.Problem: P011 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23137028021
What changed in gdc-nas
36a823e:feat(tabular-exporter): respect grand-total-possition in PDFs in ADgrandTotalsPosition(enum:pinnedBottom,pinnedTop,bottom,top) toTabularExportRequest.Settingsin three OpenAPI specs (automation, export-controller, metadata-api)GrandTotalsPosition) toTabularExportRequest.Settingsinexport.protoExportDefinition.ktwithGrandTotalsPosition.toProto()mappingTabularExportService.ktandResultMetadataBuilder.ktto pass the new field throughcsv_exporter.py,html_exporter.py,xlsx_exporter.py,result_table.py,request_handler.py) to honorgrand_totals_positionWhat was implemented in SDK
GrandTotalsPositionTypeAlias (Literal['pinnedBottom', 'pinnedTop', 'bottom', 'top']) torequest.pygrand_totals_position: GrandTotalsPosition | None = NonetoExportSettingsattrs classGrandTotalsPositionfromgooddata_sdk/__init__.pyfor user-facing APItest_export_settings_grand_totals_positionverifying all four enum values andNoneFiles modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/export/request.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/export/test_export_service.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low