docs(gooddata-sdk): [AUTO] add filter_context to object_types enum in search_ai docstring#1423
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
docs(gooddata-sdk): [AUTO] add filter_context to object_types enum in search_ai docstring#1423yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
… search_ai docstring Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1423 +/- ##
=======================================
Coverage 77.36% 77.36%
=======================================
Files 228 228
Lines 14775 14775
=======================================
Hits 11430 11430
Misses 3345 3345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
filter_contextto the validobject_typesenum values documented insearch_ai()to reflect the new ObjectType added in the gen-ai OpenAPI spec.P007 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23137028021
What changed in gdc-nas
feat(gen-ai): refactor metadata generation and filter handling (#21356)): Addedfilter_contextto theObjectTypeenum inopen-api-spec.json, enabling filter_context objects to be included in metadata sync alongside dashboards and visualizations. Internal gen-ai refactoring: replacedMetadataSkill, introduced filter sync logic for dashboards, enhancedGetObjectWithChildrenToolfor resync support.attributes(array of strings) field to the gen-aiRankingFiltermodel inopen-api-spec.json; removedattributefrom the required fields list, consolidating single/multi-attribute ranking filter support into one model.What was implemented in SDK
Updated the
object_typesparameter docstring incompute/service.pysearch_ai()to includefilter_contextalongside the existing valid enum values (attribute,metric,fact,label,date,dataset,visualization,dashboard). The passthrough at line 309 already works without logic changes; this is a documentation-only fix to keep the public API contract accurate.The
AacQueryFilter.attributesfield addition andRankingFiltermodel changes affect only the auto-generatedgooddata-api-clientlayer; no SDK wrapper model directly wraps these types.Files modified
packages/gooddata-sdk/src/gooddata_sdk/compute/service.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low