Skip to content

docs(gooddata-sdk): [AUTO] add filter_context to object_types enum in search_ai docstring#1423

Closed
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P007-add-filter-context-object-type
Closed

docs(gooddata-sdk): [AUTO] add filter_context to object_types enum in search_ai docstring#1423
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P007-add-filter-context-object-type

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Add filter_context to the valid object_types enum values documented in search_ai() to reflect the new ObjectType added in the gen-ai OpenAPI spec.

P007 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23137028021

What changed in gdc-nas

  • Commit 78f71529 (feat(gen-ai): refactor metadata generation and filter handling (#21356)): Added filter_context to the ObjectType enum in open-api-spec.json, enabling filter_context objects to be included in metadata sync alongside dashboards and visualizations. Internal gen-ai refactoring: replaced MetadataSkill, introduced filter sync logic for dashboards, enhanced GetObjectWithChildrenTool for resync support.
  • Commit 4fa9bc2d (Merge PR #21357 / GDAI-1455): Added attributes (array of strings) field to the gen-ai RankingFilter model in open-api-spec.json; removed attribute from the required fields list, consolidating single/multi-attribute ranking filter support into one model.

What was implemented in SDK

Updated the object_types parameter docstring in compute/service.py search_ai() to include filter_context alongside the existing valid enum values (attribute, metric, fact, label, date, dataset, visualization, dashboard). The passthrough at line 309 already works without logic changes; this is a documentation-only fix to keep the public API contract accurate.

The AacQueryFilter.attributes field addition and RankingFilter model changes affect only the auto-generated gooddata-api-client layer; no SDK wrapper model directly wraps these types.

Files modified

  • packages/gooddata-sdk/src/gooddata_sdk/compute/service.py

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

… search_ai docstring

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (b95ca11) to head (16a201d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1423   +/-   ##
=======================================
  Coverage   77.36%   77.36%           
=======================================
  Files         228      228           
  Lines       14775    14775           
=======================================
  Hits        11430    11430           
  Misses       3345     3345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants