Skip to content

feat(gooddata-sdk): [AUTO] Add GEO_ICON to GoodDataLabelType enum#1422

Closed
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P010-add-geo-icon-label-type
Closed

feat(gooddata-sdk): [AUTO] Add GEO_ICON to GoodDataLabelType enum#1422
yenkins-admin wants to merge 1 commit intomasterfrom
feature/auto-P010-add-geo-icon-label-type

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

@yenkins-admin yenkins-admin commented Mar 16, 2026

Add GEO_ICON to the GoodDataLabelType enum in gooddata-dbt to match the new label type added in gdc-nas.
Problem: P010 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23137028021

What changed in gdc-nas

Commit f9a6963 (merged via PR #21320) added GEO_ICON as a new LabelType enum value across multiple layers:

  • CommonModel.kt (metadata-model): added GEO_ICON between GEO_AREA and IMAGE
  • LabelType.kt (execution-data-contracts): added GEO_ICON with proto mapping
  • execution-response.proto: added GEO_ICON = 8 to ValueType enum
  • metadata.proto: added GEO_ICON = 8 to LabelType enum
  • DefaultPreprocessingContextProvider.kt: added MetadataLabelType.GEO_ICON -> LabelType.GEO_ICON mapping
  • Label.kt gRPC extension: added bidirectional LabelTypeGrpc.GEO_ICON <-> LabelType.GEO_ICON mapping
  • afm-exec-api and metadata-api OpenAPI specs: updated all valueType/labelType enum lists to include GEO_ICON

Related Jira ticket: F1-2299

What was implemented in SDK

Added GEO_ICON = 'GEO_ICON' to the GoodDataLabelType enum in gooddata-dbt/base.py, positioned after GEO_AREA to mirror the ordering in CommonModel.kt. The gooddata-sdk and gooddata-flexconnect layers use passthrough strings and required no changes. The gooddata-api-client is auto-generated and was not modified.

Files modified

  • sdk/packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py — added GEO_ICON enum value
  • sdk/packages/gooddata-dbt/tests/test_tables.py — added unit test verifying GoodDataLabelType.GEO_ICON value

JIRA: PENDING (Jira ticket will be created after review)
Risk: Low

Add GEO_ICON as a new value to the GoodDataLabelType enum in gooddata-dbt,
mirroring the GEO_ICON addition to LabelType in gdc-nas CommonModel.kt.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.36%. Comparing base (b95ca11) to head (a1b6da1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1422   +/-   ##
=======================================
  Coverage   77.36%   77.36%           
=======================================
  Files         228      228           
  Lines       14775    14776    +1     
=======================================
+ Hits        11430    11431    +1     
  Misses       3345     3345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98 hkad98 closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants