feat(gooddata-sdk): [AUTO] Add GEO_ICON to GoodDataLabelType enum#1422
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] Add GEO_ICON to GoodDataLabelType enum#1422yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
Add GEO_ICON as a new value to the GoodDataLabelType enum in gooddata-dbt, mirroring the GEO_ICON addition to LabelType in gdc-nas CommonModel.kt.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1422 +/- ##
=======================================
Coverage 77.36% 77.36%
=======================================
Files 228 228
Lines 14775 14776 +1
=======================================
+ Hits 11430 11431 +1
Misses 3345 3345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GEO_ICON to the GoodDataLabelType enum in gooddata-dbt to match the new label type added in gdc-nas.
Problem: P010 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23137028021
What changed in gdc-nas
Commit f9a6963 (merged via PR #21320) added
GEO_ICONas a newLabelTypeenum value across multiple layers:CommonModel.kt(metadata-model): addedGEO_ICONbetweenGEO_AREAandIMAGELabelType.kt(execution-data-contracts): addedGEO_ICONwith proto mappingexecution-response.proto: addedGEO_ICON = 8toValueTypeenummetadata.proto: addedGEO_ICON = 8toLabelTypeenumDefaultPreprocessingContextProvider.kt: addedMetadataLabelType.GEO_ICON -> LabelType.GEO_ICONmappingLabel.ktgRPC extension: added bidirectionalLabelTypeGrpc.GEO_ICON <-> LabelType.GEO_ICONmappingafm-exec-apiandmetadata-apiOpenAPI specs: updated allvalueType/labelTypeenum lists to includeGEO_ICONRelated Jira ticket: F1-2299
What was implemented in SDK
Added
GEO_ICON = 'GEO_ICON'to theGoodDataLabelTypeenum ingooddata-dbt/base.py, positioned afterGEO_AREAto mirror the ordering inCommonModel.kt. Thegooddata-sdkandgooddata-flexconnectlayers use passthrough strings and required no changes. Thegooddata-api-clientis auto-generated and was not modified.Files modified
sdk/packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py— addedGEO_ICONenum valuesdk/packages/gooddata-dbt/tests/test_tables.py— added unit test verifyingGoodDataLabelType.GEO_ICONvalueJIRA: PENDING (Jira ticket will be created after review)
Risk: Low