feat(gooddata-sdk): [AUTO] add Arrow binary result retrieval support (CQ-104)#1421
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] add Arrow binary result retrieval support (CQ-104)#1421yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…CQ-104)
Add ArrowFormat TypeAlias and read_result_binary() methods to BareExecutionResponse
and Execution, delegating to the new retrieve_result_binary() API endpoint
(/result/{resultId}/binary). Export ArrowFormat from gooddata_sdk.__init__.
Add unit tests verifying correct accept header forwarding for both Arrow formats.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
=======================================
Coverage 77.36% 77.36%
=======================================
Files 228 228
Lines 14775 14784 +9
=======================================
+ Hits 11430 11437 +7
- Misses 3345 3347 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Arrow binary result retrieval to gooddata-sdk by exposing the new
/result/{resultId}/binaryendpoint viaread_result_binary()methods onBareExecutionResponse,Execution, andComputeService.P001 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23137028021
What changed in gdc-nas
Two PRs introduced Apache Arrow IPC format support to the AFM Execute Result API:
ArrowResultCacheReaderandArrowResultProcessorhelper classes./binarysub-path. New endpoint:GET /api/v1/actions/workspaces/{workspaceId}/execution/afm/execute/result/{resultId}/binary(operationIdretrieveResultBinary), supporting bothapplication/vnd.apache.arrow.fileandapplication/vnd.apache.arrow.streammedia types via theAcceptheader.What was implemented in SDK
ArrowFormatTypeAlias (Literal['application/vnd.apache.arrow.file', 'application/vnd.apache.arrow.stream']) toexecution.pyBareExecutionResponse.read_result_binary(accept: ArrowFormat) -> bytescallingretrieve_result_binary()on the actions APIExecution.read_result_binary(accept: ArrowFormat) -> bytesdelegating toBareExecutionResponseComputeService.retrieve_result_binary()convenience method for callers that bypassExecutionobjectsArrowFormatfromgooddata_sdk.__init__Files modified
packages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/src/gooddata_sdk/compute/service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_read_result_binary.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low