fix(gooddata-sdk): [AUTO] make CatalogLlmProviderAttributes.models and provider_config nullable#1420
Closed
yenkins-admin wants to merge 1 commit intomasterfrom
Closed
Conversation
…d provider_config nullable Makes models and provider_config fields optional (| None = None) in CatalogLlmProviderAttributes to match the updated OpenAPI spec that removed these fields from the required[] array and added nullable:true to providerConfig. This fixes deserialization of PATCH responses where these fields may be absent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1420 +/- ##
=======================================
Coverage 77.36% 77.36%
=======================================
Files 228 228
Lines 14775 14775
=======================================
Hits 11430 11430
Misses 3345 3345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
CatalogLlmProviderAttributes.modelsandprovider_confignullable to align with updated OpenAPI spec from GDAI-1350.Problem ID: P003 | Workflow: https://github.com/gooddata/gdc-nas/actions/runs/23137028021
What changed in gdc-nas
Two commits landed in gdc-nas to fix a 500 error on PATCH
LlmProvideroperations (GDAI-1350):LlmProvider.providerConfigandLlmProvider.modelsnullable in the Kotlin model (LlmProviderConfig? = null,List<LlmModel>? = null). AddedrequireNotNullvalidation inLlmProviderValidatorfor POST/PUT. UpdatedEncryptionServiceandOrganizationApiStockServicefor null-safe calls. Addedpatch.jsontest fixture that patches only the name field.modelsandproviderConfigfromrequired[]inLlmProviderattributes schema; removedattributesfromrequired[]inJsonApiLlmProviderPatch,JsonApiLlmProviderIn, andJsonApiLlmProviderOutdocuments; addednullable: truetoproviderConfigin those three schema locations.What was implemented in SDK
Updated
CatalogLlmProviderAttributesin the SDK wrapper to reflect the updated OpenAPI schema:models:list[CatalogLlmProviderModel]→list[CatalogLlmProviderModel] | None = Noneprovider_config:CatalogLlmProviderConfig→CatalogLlmProviderConfig | None = NoneCatalogLlmProviderPatchAttributesalready had both fields optional — no change needed there.CatalogLlmProvider.from_api()already usedsafegetwith fallbacks, so it handles null values from API responses safely.Files modified
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.pyJIRA: PENDING (Jira ticket will be created after review)
Risk: Low