feat(catalog): add column description support#1260
Open
tychtjan wants to merge 2 commits into
Open
Conversation
tychtjan
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Add optional description field to SqlColumn and CatalogDeclarativeColumn to support database column comments. This enables passing column descriptions from scanModel API to LDM generation. risk: low jira: DX-312
Add comprehensive tests for SqlColumn and CatalogDeclarativeColumn description field including: - Creation with/without description - API conversion (to_api/from_api) - Equality comparison - Integration with CatalogPdmSql risk: nonprod jira: DX-312
tychtjan
force-pushed
the
feature/dx-312-column-descriptions
branch
from
a5f81c1 to
dbf442a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1260 +/- ##
==========================================
+ Coverage 79.03% 79.05% +0.01%
==========================================
Files 231 231
Lines 15634 15636 +2
==========================================
+ Hits 12357 12361 +4
+ Misses 3277 3275 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
descriptionfield toSqlColumnandCatalogDeclarativeColumnto support database column comments. This enables passing column descriptions from the scanModel API to LDM generation.When databases like Snowflake have column comments defined (e.g.,
COMMENT ON COLUMN table.column IS 'description'), these are now captured during scanning and can be used as descriptions for facts, attributes, labels in the generated LDM.Changes
description: Optional[str] = Nonefield toSqlColumnclassdescription: Optional[str] = Nonefield toCatalogDeclarativeColumnclassTesting
make formatpassesRisk Assessment
Related
Checklist