refactor: use IDs based on the parent block ID for block comments #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
force-pushed
the
stable-comment-ids
branch
from
894013e to
bfbc83e
Compare
rachel-fenichel
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
This PR builds towards resolving #84. Built-in Blockly block comments do not have IDs, because they're just represented as part of the block. Scratch's old implementation did have IDs, which get serialized and are tracked by the VM to maintain its internal state in response to block comment events.
This change makes block comment IDs the same as their parent block's ID with
_commentsuffix. In partnership with a forthcoming PR in -vm, this will allow for consistent comment IDs between -blocks and -vm, which in turn fixes the interop issues described in #84.Additionally, this PR fixes a bug that could cause the workspace and VM state to get out of sync due to events fired during block deserialization being suppressed.