This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Fix WIT generation #316
Merged
Fix WIT generation #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigoo
approved these changes
Aug 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a very minor fix. The
app buildfor code first agent was stuck at this point when expanding the example with more types, and its 1 liner fixContext: Two things.
If name is not available, we use
elementas a proposed name with a counter with logic to not use existing names.I will ensure the TS SDK emits actual parameter-names - for better experience altogether - in the next immediate version.
But that said, when the name was not available, the
golem app buildgot stuck due to a minor bug in name lookups, and this PR simply fixes it