Mark template function in math_funcs_binary constexpr#118027
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Mar 31, 2026
Merged
Mark template function in math_funcs_binary constexpr#118027Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Ivorforce
approved these changes
Mar 31, 2026
dsnopek
approved these changes
Mar 31, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In fixing a compile error of my gdextension I noticed the inconsistency of using
inline,inline static,constexprbetweengodot-cpp(include/godot_cpp/core/defs.hpp) andgodot(core/math/math_funcs_binary.h). The detail of my issue can be found below:godotengine/godot-cpp#1962
godotusesconstexprfor most of functions in that file except for the two template functionsis_power_of_2andnearest_power_of_2_templatedwhich use justinline.godot-cppusesstatic inlineeverywhere, and thestatic inlinetemplate function made my gdextension lib fail to build. Though I am not sure if it is a real error according to C++ standard or is just a clang bug with module, but I thinkstatic inlineis not something appropriate in modern C++. So to be consistent I suggest that we put everythingconstexprwhile possible. For the engine the only change is the two template functions.