Switch include order of Godot.hpp and Ref.hpp#541
Open
founderio wants to merge 1 commit intogodotengine:masterfrom
Open
Switch include order of Godot.hpp and Ref.hpp#541founderio wants to merge 1 commit intogodotengine:masterfrom
founderio wants to merge 1 commit intogodotengine:masterfrom
Conversation
founderio
force-pushed
the
bugfix/undefined_ref_object_cast_to
branch
from
b6d3f87 to
5a48a0a
Compare
As Ref<T> uses Object::cast_to<T>, which is defined in Godot.hpp, the includes need to be the other way around to work consistently. If not done like this, inconsistent behaviour during linking/loading may occur and produce errors like this: undefined symbol: _ZN5godot6Object7cast_toINS_15SpatialMaterialEEEPT_PKS0_
founderio
force-pushed
the
bugfix/undefined_ref_object_cast_to
branch
from
5a48a0a to
7236a4b
Compare
Member
|
@founderio Is this PR still relevant for Godot 4.x and GDExtension? Also, this PR has conflicts that need to be resolved before this can be considered, can you rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Ref uses Object::cast_to, which is defined in Godot.hpp,
the includes need to be the other way around to work consistently.
If not done like this, inconsistent behaviour during linking/loading
may occur and produce errors like this:
undefined symbol:
ZN5godot6Object7cast_toINS_15SpatialMaterialEEEPT_PKS0
There is a more detailed description in the related issue:
Fixes #540
I am not sure if the include of
Ref.hppinGodot.hppwas intentional, thus open for discussion.Due to that fact: People are using
Ref<T>while only includingGodot.hpp, which means this is a breaking change.Not sure if there is a way to solve this without breakage. Maybe move the definition of
Object::cast_to<T>to a separate header and include that?