Skip to content

Cherry-pick #1904: fix _get_property_list failing in thread scenarios#1928

Merged
dsnopek merged 1 commit intogodotengine:4.5from
Zylann:cherrypick_1904_godot45
Feb 16, 2026
Merged

Cherry-pick #1904: fix _get_property_list failing in thread scenarios#1928
dsnopek merged 1 commit intogodotengine:4.5from
Zylann:cherrypick_1904_godot45

Conversation

@Zylann
Copy link
Collaborator

@Zylann Zylann commented Feb 16, 2026

My latest extension build still uses GodotCpp from the godot-4.5-stable tag for compatibility, but is crashing in Godot 4.6 when expanding custom resources in the inspector (call stack indicates it's not the main thread):
image
With a similar error in the console:

ERROR: Internal error, property list was not freed by engine!
   at: zylann::voxel::VoxelBlockyModelCube::get_property_list_bind (D:\Projets\Info\Godot\Engine\godot4_fork\modules\voxel\meshers/blocky/voxel_blocky_model_cube.h:11)

That #1904 seems to fix.

Btw, should I then use the 4.5 branch instead of the godot-4.5-stable tag when building releases? Given fixes may have been done, it seems tags are a bit useless besides marking the "first version supporting Godot x.x"

@Zylann Zylann requested a review from a team as a code owner February 16, 2026 00:44
@dsnopek
Copy link
Collaborator

dsnopek commented Feb 16, 2026

We can certainly cherry-pick this! I'm not sure why I didn't mark it for cherry-picking initially

However, I just wanted to point out that master is compatible with Godot 4.5 - you just need to build with scons api_version=4.5

Btw, should I then use the 4.5 branch instead of the godot-4.5-stable tag when building releases? Given fixes may have been done, it seems tags are a bit useless besides marking the "first version supporting Godot x.x"

In the old versioning scheme, yeah, using the 4.5 branch is a good idea, because we only previously made releases synchronized with Godot releases, and so if you only used tags you would miss most of the fixes we regularly cherry-pick

@dsnopek dsnopek added bug This has been identified as a bug crash labels Feb 16, 2026
@dsnopek dsnopek added this to the 4.5 milestone Feb 16, 2026
@dsnopek dsnopek merged commit f00f83d into godotengine:4.5 Feb 16, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug crash

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants