Skip to content

let checkout-api raise error on confirm for sync#1381

Merged
wcole1-godaddy merged 1 commit into
mainfrom
fix-shipping-address-error-thrown
May 29, 2026
Merged

let checkout-api raise error on confirm for sync#1381
wcole1-godaddy merged 1 commit into
mainfrom
fix-shipping-address-error-thrown

Conversation

@pbennett1-godaddy
Copy link
Copy Markdown
Collaborator

Summary

Fixes the checkout error surfaced when a shipping order is blocked because shipping lines or line item fulfillment data are missing.

The fulfillment resync flow attempts to re-apply the selected shipping method when line items are still in NONE fulfillment mode. If checkout is still blocked, the user-facing error should be the
existing missing shipping info error (MISSING_SHIPPING_INFO / “Shipping address or method failed to apply”), rather than the more generic shipping method application error.

This keeps the checkout-blocking validation aligned with the checkout-api confirm behavior and avoids surfacing the background resync mutation error directly to shoppers.

Changeset

Test Plan

  • Verified the code path in useConfirmCheckout now returns MISSING_SHIPPING_INFO when shipping checkout is blocked by missing shipping lines or line items still missing shipping fulfillment.
  • Verified the fulfillment resync mutation in shipping-method.tsx still invalidates the draft order on success so updated line item fulfillment state is refetched.
  • Verified the resync mutation no longer sets a local SHIPPING_METHOD_APPLICATION_FAILED checkout error on failure; checkout confirmation remains responsible for surfacing the canonical missing
    shipping info error.
  • Confirmed the related Playwright e2e expectations continue to use the existing “Shipping address or method failed to apply” message.

@pbennett1-godaddy pbennett1-godaddy requested a review from a team as a code owner May 29, 2026 17:56
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 29, 2026

🦋 Changeset detected

Latest commit: c51f1dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@godaddy/react Patch
nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wcole1-godaddy wcole1-godaddy merged commit 9a03ad9 into main May 29, 2026
3 checks passed
@wcole1-godaddy wcole1-godaddy deleted the fix-shipping-address-error-thrown branch May 29, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants