feat(tls): Adding option to skip TLS verification#76
Open
odg0318 wants to merge 1 commit into
Open
Conversation
Author
|
@thoward-godaddy Hi, can you review my PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, team.
This is PR including a feature adding an option to skip TLS verification over HTTPS.
Generally, OKTA is integrated with enterprise environment such a company.
And in the company, infrastructure are secured under a kind of mitm firewall.
As a result, TLS verification could be failed because of firewall so that this feature is required as a workaround.
The option name I added is
--no-tls-verifyfollowing--no-okta-cacheor--no-aws-cache.And the option is used to make a request to AWS API using
boto3and HTTP API usingrequests.Please review my PR and don't hesitate to feedback if you any concern.
Thanks