Fix EOL MySQL image, remove dead test helper, gitignore .npmrc#145
Merged
jgowdy-godaddy merged 2 commits intomainfrom Mar 4, 2026
Merged
Fix EOL MySQL image, remove dead test helper, gitignore .npmrc#145jgowdy-godaddy merged 2 commits intomainfrom
jgowdy-godaddy merged 2 commits intomainfrom
Conversation
MySQL 5.7 reached end of life in October 2023. Switch all references to mysql:latest so we automatically pick up new releases. Also drop --platform linux/amd64 from local scripts since mysql:latest provides native ARM images.
get_sample_json was never called and had a broken JSON.stringify replacer. Also gitignore .npmrc to prevent accidental commit of the temporary auth token file created during CI publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local-integration-test.sh, andintegration/node/run-local.sh. Also dropped unnecessary--platform linux/amd64from local scripts sincemysql:latesthas native ARM images.get_sample_json: Never called anywhere; also had a brokenJSON.stringifyreplacer (['nested.secret']doesn't work as a dotted path). Removed along with the now-unusedcryptoimport..npmrcto.gitignore:publish.ymlcreates a temporary.npmrcwith the NPM auth token. Gitignoring it prevents accidental commit of credentials.Test plan