fix: add context to error messages for better debugging#126
Merged
jgowdy-godaddy merged 1 commit intomainfrom Mar 4, 2026
Merged
fix: add context to error messages for better debugging#126jgowdy-godaddy merged 1 commit intomainfrom
jgowdy-godaddy merged 1 commit intomainfrom
Conversation
c517e9f to
cfbb8a1
Compare
jgowdy
approved these changes
Feb 12, 2026
edc31e3 to
4b169f3
Compare
- Add function name prefixes to all CobhanBuffer error messages - Add 2GB limit clarification to size-related error messages - Fix set_data_len_bytes message to accurately say "maximum data size" - Replace napi_throw_error with NapiUtils::ThrowException in ToString() for consistent error handling via C++ exceptions
4b169f3 to
68e9a6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
napi_throw_errorwithNapiUtils::ThrowExceptionExamples
Before:
After:
Benefits
Test plan
🤖 Generated with Claude Code