Add first-class callable syntax support to NodeExpressionResolver by Copilot · Pull Request #193 · goaop/parser-reflection

Copilot · 2026-04-29T17:22:53Z

NodeExpressionResolver had no handler for PHP 8.1+ first-class callable syntax (strlen(...) / Foo::bar(...)), causing a confusing "Cannot statically resolve a variadic placeholder argument" error instead of a meaningful result or clear failure.

Changes

resolveExprFuncCall — detects isFirstClassCallable() early; returns Closure::fromCallable($name) for internal functions; for user-defined functions, sets isConstExpr = true before throwing ReflectionException so callers can catch the exception and reconstruct the FCC expression as code for proxy generation
resolveExprStaticCall (new) — handles ClassName::method(...); accepts both built-in and user-defined static methods, sets isConstExpr = true, and returns Closure::fromCallable('ClassName::method') (class loading may occur and can be intercepted by the AOP framework)
resolveExprMethodCall (new) — always throws a clear ReflectionException; instance method callables require a runtime object and can never be statically resolved
ReflectionParameter::getDefaultValueExpression() (new) — returns the string representation of a FCC or other constant-expression default (e.g. '\strlen(...)'), needed to reconstruct proxied code; constructor now catches ReflectionException from FCC resolution and stores the expression string
ReflectionProperty::getDefaultValueExpression() (new) — same as above for properties; __toString() updated to use the const-expression string when available

// Built-in function → returns a live Closure
$expressionSolver->process($parser->parse("<?php strlen(...);")[0]);
$closure = $expressionSolver->getValue(); // instanceof \Closure
$closure('foobar'); // 6

// Built-in static method → returns a live Closure
$expressionSolver->process($parser->parse("<?php \DateTime::createFromFormat(...);")[0]);
$closure = $expressionSolver->getValue(); // instanceof \Closure

// User-defined function → throws ReflectionException, but isConstExpression() is true
// so callers can call getConstExpression() → '\Go\MyNs\myFunc(...)'

// User-defined static method → returns a live Closure (class loading is interceptable by AOP)
$expressionSolver->process($parser->parse("<?php \My\Class::method(...);")[0]);
$closure = $expressionSolver->getValue(); // instanceof \Closure

// Instance method → throws ReflectionException
// "First-class callable syntax for instance methods ($obj->method(...)) cannot be resolved
//  statically, as it requires a runtime object instance."

// ReflectionParameter with FCC default
$param->getDefaultValueExpression(); // '\strlen(...)'
(string) $param; // "Parameter #0 [ <optional> $callable = \strlen(...) ]"

Agent-Logs-Url: https://github.com/goaop/parser-reflection/sessions/af3a37d7-899a-4cc3-912d-fc53451d726f Co-authored-by: lisachenko <640114+lisachenko@users.noreply.github.com>

lisachenko

missing test stub files and checks for ReflectionParameter and ReflectionProperty if they support FCC

lisachenko · 2026-05-07T07:05:35Z

+        if (!is_callable($callable)) {
+            throw new ReflectionException("'{$callable}' is not callable and cannot be used as a first-class callable.");
+        }
+        $reflectedMethod = new \ReflectionMethod($className, $methodName);


we should not use here a reflection, this may cause class-loading and it is against our general way of doing this, so we need to set the isConstExpr = true, set the expression itself and then call the Closure::fromCallable

Done in c662388 — removed \ReflectionMethod usage entirely. Now sets $this->isConstExpr = true before calling Closure::fromCallable($callable), which handles both built-in and user-defined static methods (with an is_callable() guard for a clean error message).

lisachenko · 2026-05-07T07:05:48Z

+            );
+        }
+
+        return \Closure::fromCallable($callable);


use import for Closure without FQN

Done in c662388 — added use Closure; import and replaced all \Closure FQN usages in the resolver.

lisachenko · 2026-05-07T07:07:17Z

+            throw new ReflectionException("'{$callable}' is not callable and cannot be used as a first-class callable.");
+        }
+        $reflectedMethod = new \ReflectionMethod($className, $methodName);
+        if ($reflectedMethod->isUserDefined()) {


we can accept here even user-defined methods too, this will cause the class-loading, but we can intercept class loading process, wrap method with advices if needed and return back a first-class-callable to woven method, so should be ok

Done in c662388 — user-defined static methods are now accepted. The isUserDefined() check via \ReflectionMethod was removed. Closure::fromCallable($callable) is called directly (class-loading will occur, which is fine for the AOP interception use-case).

lisachenko · 2026-05-07T07:08:07Z

+            if (!is_string($functionName)) {
+                throw new ReflectionException("Could not resolve function name for first-class callable.");
+            }
+            $reflectedFunction = new \ReflectionFunction($functionName);


use import for ReflectionFunction

Done in c662388 — added use ReflectionFunction; to the imports and replaced all \ReflectionFunction FQN usages.

lisachenko · 2026-05-07T07:44:55Z

+
+        // Define a user function to test with
+        if (!function_exists('Go\ParserReflection\Resolver\testUserDefinedFunction')) {
+            eval('namespace Go\\ParserReflection\\Resolver; function testUserDefinedFunction() {}');


do not use eval here, it is prohibited to use eval in the parser-reflection library, just load one from existing tests

Done in c662388 — removed eval(). The test now does require_once __DIR__ . '/../Stub/FileWithFunctions55.php' and uses Go\ParserReflection\Stub\simpleNoArgs (an existing user-defined stub function).

lisachenko · 2026-05-07T07:46:00Z

+        $this->expectExceptionMessageMatches('/user-defined function.*cannot be resolved/');
+
+        // Define a user function to test with
+        if (!function_exists('Go\ParserReflection\Resolver\testUserDefinedFunction')) {


also, do not check the function_exists, as we operating on parser-reflection level and we don't need to load anything in memory

Done in c662388 — removed the function_exists() check. The test uses a real stub function via require_once.

…ods, stub, fixed tests Agent-Logs-Url: https://github.com/goaop/parser-reflection/sessions/ba799072-2236-43cf-8f08-6e63ca00dddc Co-authored-by: lisachenko <640114+lisachenko@users.noreply.github.com>

…ession format Agent-Logs-Url: https://github.com/goaop/parser-reflection/sessions/ba799072-2236-43cf-8f08-6e63ca00dddc Co-authored-by: lisachenko <640114+lisachenko@users.noreply.github.com>

Copilot · 2026-05-07T08:18:18Z

missing test stub files and checks for ReflectionParameter and ReflectionProperty if they support FCC

Done in c662388:

Added tests/Stub/FileWithFunctionsFcc.php — a parse-only stub (not require_once'd, since PHP runtime rejects FCC in constant-expression positions) with functions bearing FCC parameter defaults
ReflectionParameter: try/catch in constructor stores const-expression on FCC, getDefaultValueExpression(): ?string added, tests in ReflectionParameterTest
ReflectionProperty: same pattern — $isDefaultValueConstExpr field added, __toString() updated, getDefaultValueExpression(): ?string added, contract test in ReflectionPropertyTest

Initial plan

847700a

Copilot AI assigned Copilot and lisachenko Apr 29, 2026

Copilot started work on behalf of lisachenko April 29, 2026 17:22 View session

Copilot AI linked an issue Apr 29, 2026 that may be closed by this pull request

Add first-class callable syntax support to NodeExpressionResolver #188

Open

Add first-class callable syntax support to NodeExpressionResolver

5a07993

Agent-Logs-Url: https://github.com/goaop/parser-reflection/sessions/af3a37d7-899a-4cc3-912d-fc53451d726f Co-authored-by: lisachenko <640114+lisachenko@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add support for first-class callable syntax in NodeExpressionResolver~~ Add first-class callable syntax support to NodeExpressionResolver Apr 29, 2026

Copilot finished work on behalf of lisachenko April 29, 2026 17:30

Copilot AI requested a review from lisachenko April 29, 2026 17:30

lisachenko requested changes May 7, 2026

View reviewed changes

Copilot started work on behalf of lisachenko May 7, 2026 07:59 View session

Copilot AI and others added 2 commits May 7, 2026 08:16

Address PR review feedback: FCC const-expr support, imports, new meth…

c662388

…ods, stub, fixed tests Agent-Logs-Url: https://github.com/goaop/parser-reflection/sessions/ba799072-2236-43cf-8f08-6e63ca00dddc Co-authored-by: lisachenko <640114+lisachenko@users.noreply.github.com>

cleanup: remove redundant ?? null, add comment for hardcoded FCC expr…

124deec

…ession format Agent-Logs-Url: https://github.com/goaop/parser-reflection/sessions/ba799072-2236-43cf-8f08-6e63ca00dddc Co-authored-by: lisachenko <640114+lisachenko@users.noreply.github.com>

Copilot finished work on behalf of lisachenko May 7, 2026 08:19

Copilot AI requested a review from lisachenko May 7, 2026 08:19

Uh oh!

Conversation

Copilot AI commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

lisachenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lisachenko May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 7, 2026

Choose a reason for hiding this comment

Uh oh!

lisachenko May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 7, 2026

Choose a reason for hiding this comment

Uh oh!

lisachenko May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 7, 2026

Choose a reason for hiding this comment

Uh oh!

lisachenko May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lisachenko May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 7, 2026

Choose a reason for hiding this comment

Uh oh!

lisachenko May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Apr 29, 2026 •

edited

Loading