[shaping] support non integer maxWidth for line wrapping #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitkugler
requested review from
andydotxyz and
whereswaldon
as code owners
andydotxyz
approved these changes
Dec 23, 2025
Contributor
andydotxyz
left a comment
andydotxyz
left a comment
There was a problem hiding this comment.
Looks good.
Not sure if the int versions need to be deprecated - if it is often using int (pixel) based limits then the old APIs support avoiding unncessary fixed conversions.
Contributor
Author
|
@whereswaldon Hi Chris, any chances you could have a look at this PR ? Thank you ! |
whereswaldon
approved these changes
Jan 19, 2026
Member
whereswaldon
left a comment
whereswaldon
left a comment
There was a problem hiding this comment.
Looks good, just noticed a typo in a comment. Sorry for the delay!
Contributor
Author
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepts a
fixed.Int26_6asmaxWidth, closes #208We should perhaps deprecate theintversions ofWrapParagraphandWrapNextLine, not sure how to proceed though.