Refactor: Table driven compiler and variable logging.#2739
Open
trulede wants to merge 1 commit intogo-task:mainfrom
Open
Refactor: Table driven compiler and variable logging.#2739trulede wants to merge 1 commit intogo-task:mainfrom
trulede wants to merge 1 commit intogo-task:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consideration.
A refactoring of the compiler to use a table driven approach, especially the
getVariables()function and introduction of variable logging to assist in Taskfile debug. No functional change.Additional?
TASK_DEBUG_COMPILER=FOO;BAR.Operation
Currently the logging is enabled by a "secret" environment variable and the
-vflag. The intention is to integrate the debug into a more capable logging framework where a log category can be assigned (see PR #2617).This logging is disabled by default because the output impacts some test fixtures ... and there is a lot of it!
Unchanged (by Task) environment variables are not printed by the logging, which reduces the volume of logs significantly, and avoids, but does not prevent, printing of sensitive data.
TASK_DEBUG_COMPILER=1 task -v -t testdata/compiler/debug_compiler/Taskfile.yml 2>&1 | less -ROutput ... there is a lot of it