templating: add resolvePath function for absolute path resolution#2737
Open
SergioChan wants to merge 1 commit intogo-task:mainfrom
Open
templating: add resolvePath function for absolute path resolution#2737SergioChan wants to merge 1 commit intogo-task:mainfrom
SergioChan wants to merge 1 commit intogo-task:mainfrom
Conversation
trulede
reviewed
Mar 12, 2026
| "IsSH": IsSH, // Deprecated | ||
| "joinPath": filepath.Join, | ||
| "relPath": filepath.Rel, | ||
| "resolvePath": resolvePath, |
Contributor
There was a problem hiding this comment.
Is more granular approach better?
absPath: filepath.Abs
evalSymlinks: filepathEvalSymlinks
Author
There was a problem hiding this comment.
Great question! I intentionally kept this as a single resolvePath helper because issue #2681 is about resolving template paths to a final usable absolute path, and exposing one focused function keeps the template surface smaller.
Current behavior is effectively:
filepath.Abs(...)- best-effort
filepath.EvalSymlinks(...) - fallback to the absolute path if symlink evaluation fails
If you prefer explicit absPath and evalSymlinks helpers instead, I can split this PR that way.
Contributor
There was a problem hiding this comment.
The general approach has been to add individual functions. I think its more useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolvePathtemplate function to resolve relative segments into an absolute pathresolvePathresolve symlinks when available, with a safe fallback to the absolute path when symlink resolution is not possibleTesting
go test ./internal/templatertoolchain not available)Related