templater: add joinEnv helper for PATH-like vars#2733
Open
SergioChan wants to merge 1 commit intogo-task:mainfrom
Open
templater: add joinEnv helper for PATH-like vars#2733SergioChan wants to merge 1 commit intogo-task:mainfrom
SergioChan wants to merge 1 commit intogo-task:mainfrom
Conversation
trulede
reviewed
Mar 14, 2026
| return shell.Fields(s, nil) | ||
| } | ||
|
|
||
| func joinEnv(elems ...string) string { |
Contributor
There was a problem hiding this comment.
I would suggest to call this function pathJoinList.
Contributor
|
A more succinct solution to duplicate #2408 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
joinEnvtemplate helper that joins path-like values with the OS-specific path list separator (:on POSIX,;on Windows)joinEnvin the templater function map so Taskfiles can build cross-platformPATHvalues cleanlyTesting
git diff --checkgo test ./internal/templater(not runnable in this environment: required Go toolchaingo1.25is unavailable viaGOTOOLCHAINdownload)Related
Fixes #2406