Skip to content

Conversation

@fredbi
Copy link
Member

@fredbi fredbi commented Dec 11, 2025

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8ff9e39) to head (54f65b0).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines            8         8           
=========================================
  Hits             8         8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors workflow waiting loops by replacing inline shell scripts with a reusable GitHub Action (go-openapi/gh-actions/ci-jobs/wait-pending-jobs). The goal is to improve code maintainability by eliminating duplicated logic across workflows.

Key changes:

  • Replaced ~40 lines of bash script per workflow with a single action reference
  • Consolidated workflow run waiting logic into a shared GitHub Action

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File Description
.github/workflows/contributors.yml Replaced inline waiting script with reusable action, removed environment variables
.github/workflows/auto-merge.yml Replaced inline waiting script with reusable action, removed environment variables

Critical Issues Found: The refactoring inadvertently removed necessary environment variables (GH_TOKEN and PR_URL) that are still required by other steps in both workflows. Additionally, in contributors.yml, the action is being passed an incorrect PR URL context that won't work with workflow_call triggers.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fredbi fredbi force-pushed the feat/factorize-wait-on-workflows branch 2 times, most recently from 2cfa11e to f310f0b Compare December 11, 2025 22:06
@fredbi fredbi requested a review from Copilot December 11, 2025 22:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi fredbi force-pushed the feat/factorize-wait-on-workflows branch from f310f0b to 54f65b0 Compare December 11, 2025 22:19
@fredbi fredbi requested a review from Copilot December 11, 2025 22:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +21 to +22
PR_URL: ${{github.event.pull_request.html_url}}
GH_TOKEN: ${{secrets.GITHUB_TOKEN}}
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's inconsistent spacing in the GitHub Actions expressions. Lines 21-22 use ${{ without a space after the opening braces, while the action parameters at lines 67-68 use ${{ with spaces. For consistency and readability, consider using consistent spacing throughout (e.g., ${{ github.event.pull_request.html_url }} and ${{ secrets.GITHUB_TOKEN }}).

Copilot uses AI. Check for mistakes.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok forthcoming PR following up

@fredbi fredbi merged commit b85bfe0 into go-openapi:master Dec 11, 2025
25 checks passed
@fredbi fredbi deleted the feat/factorize-wait-on-workflows branch December 11, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant