test: removed special case for handling testing dirs on windows #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 17 17
Lines 2021 2021
=======================================
Hits 1861 1861
Misses 107 107
Partials 53 53 ☔ View full report in Codecov by Sentry. |
fredbi
force-pushed
the
test/use-testing-tempdir
branch
from
9a078aa to
5f42719
Compare
golang/go#71544 is still officially open. However a fix has been committed to go codebase. This issue is not really blocking: the problem lies on windows not reliaby cleaning up the temporary directory. Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
test/use-testing-tempdir
branch
from
5f42719 to
b4b944e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang/go#71544 is still officially open. However a fix has been committed to go codebase.
This issue is not really blocking: the problem lies on windows not reliaby cleaning up the temporary directory.