Skip to content

Add code to handle NSDiffableDataSource#378

Merged
gcasa merged 64 commits intomasterfrom
NSDiffableDataSource_branch
Feb 23, 2026
Merged

Add code to handle NSDiffableDataSource#378
gcasa merged 64 commits intomasterfrom
NSDiffableDataSource_branch

Conversation

@gcasa
Copy link
Copy Markdown
Member

@gcasa gcasa commented Jan 4, 2026

The test for this is in https://github.com/gcasa/NSDiffableDataSource_test.git

diffable_gs

The test on the mac:

test_mac

@gcasa gcasa force-pushed the NSDiffableDataSource_branch branch from df2da0f to 90a8419 Compare January 19, 2026 15:32
@gcasa gcasa force-pushed the NSDiffableDataSource_branch branch from 926a924 to 1ac2073 Compare January 20, 2026 13:08
@gcasa gcasa changed the title Add initial cut for diffable data source. Add code to handle NSDiffableDataSource Jan 22, 2026
@gcasa gcasa marked this pull request as ready for review January 22, 2026 09:45
@gcasa gcasa requested a review from fredkiefer as a code owner January 22, 2026 09:45
@gcasa
Copy link
Copy Markdown
Member Author

gcasa commented Jan 22, 2026

Ready for review.

@gcasa
Copy link
Copy Markdown
Member Author

gcasa commented Feb 13, 2026

I notice lots of enumerator based while loops. Should we expose the FOR_IN macro from GSFastEnumeration.h in the base library, so that GUI code can use fast enumeration irrespective of what compiler is in use?

Not only would itrun those loops faster, it would also make the code shorter and more readable/maintainable.

I have replaced every instance of this with FOR_IN(...).

@gcasa
Copy link
Copy Markdown
Member Author

gcasa commented Feb 20, 2026

@fredkiefer, let me know what else I need to change. I believe I have addressed everything. Any other issues can be addressed in a separate PR.

@gcasa
Copy link
Copy Markdown
Member Author

gcasa commented Feb 21, 2026

@fredkiefer Are you okay with merging this?

Comment thread Source/NSDiffableDataSource.m Outdated
Comment thread Source/NSDiffableDataSource.m Outdated
Comment thread Tests/gui/NSDiffableDataSource/NSDiffableDataSource_collectionView.m Outdated
Comment thread Source/NSDiffableDataSource.m Outdated
Comment thread Source/NSDiffableDataSource.m Outdated
Comment thread Source/NSDiffableDataSource.m Outdated
Comment thread Source/NSDiffableDataSource.m Outdated
Comment thread Source/NSDiffableDataSource.m Outdated
Comment thread Source/NSDiffableDataSource.m Outdated
Comment thread Source/NSDiffableDataSource.m Outdated
Copy link
Copy Markdown
Member

@fredkiefer fredkiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still must admit that I did only understand less than half the code in this PR. It is way too big for me to properly review. But if you yourself feel comfortable with the changes, go ahead and merge them.

Removed unnecessary import of objc/runtime.h
@gcasa
Copy link
Copy Markdown
Member Author

gcasa commented Feb 23, 2026

@fredkiefer Merging, per your comment.

@gcasa gcasa merged commit 93a8a12 into master Feb 23, 2026
4 checks passed
@gcasa gcasa deleted the NSDiffableDataSource_branch branch February 23, 2026 18:56
@gcasa
Copy link
Copy Markdown
Member Author

gcasa commented Feb 23, 2026

I will work to reduce the size of PRs moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants