Add method that tells the app/backend that we are using a dark mode theme#326
Add method that tells the app/backend that we are using a dark mode theme#326
Conversation
…of it being hard coded
|
A discussed via voice, I think we need two properties:
The latter porperty is for future work, non need to implement it now. isDarkMode in this context is a little bit ambiguous. |
run. In the future, like Aqua, we might support Themes having both Light and Dark Appearance. Change wording from Mode to Appearance, since Apple has NSAppearance.
|
made an API improvement based on what I think matches closer what we need and adapted naming to what I discovered in Cocoa. |
|
Why was this closed without explanation? |
…of it being hard coded
run. In the future, like Aqua, we might support Themes having both Light and Dark Appearance. Change wording from Mode to Appearance, since Apple has NSAppearance.
…libs-gui into GSTheme_darkmode_branch
|
I think this is still a valid path to pursue, I rebased branch to master and reopen. |
Because I wasn't sure if this was the right approach. Are you sure this is the right way to go? Some of this functionality needs to reside in the backend as well. The issue is that the theme is affecting how printing is processed. It is a mystery to me how macOS handles this because some apps print exactly what is in the view and some don't. So pinning down exactly what is done at the basic level is difficult without us writing our own word processing application which is no small feat. |
The purpose of this PR is to add a method to make the system aware that a theme using "dark mode" is being used. This will assist in settings for editors and, particularly, with printing.