Skip to content

Add method that tells the app/backend that we are using a dark mode theme#326

Draft
gcasa wants to merge 11 commits intomasterfrom
GSTheme_darkmode_branch
Draft

Add method that tells the app/backend that we are using a dark mode theme#326
gcasa wants to merge 11 commits intomasterfrom
GSTheme_darkmode_branch

Conversation

@gcasa
Copy link
Copy Markdown
Member

@gcasa gcasa commented Jan 5, 2025

The purpose of this PR is to add a method to make the system aware that a theme using "dark mode" is being used. This will assist in settings for editors and, particularly, with printing.

@rmottola
Copy link
Copy Markdown
Member

A discussed via voice, I think we need two properties:

  • Theme "is dark". When switched system issues dark mode notification and identifies as darkmode.
  • Theme supports both light and dark modes

The latter porperty is for future work, non need to implement it now.

isDarkMode in this context is a little bit ambiguous.

run. In the future, like Aqua, we might support Themes having both Light
and Dark Appearance.
Change wording from Mode to Appearance, since Apple has NSAppearance.
@rmottola
Copy link
Copy Markdown
Member

rmottola commented Jun 9, 2025

made an API improvement based on what I think matches closer what we need and adapted naming to what I discovered in Cocoa.
Still, "guts" is empty.
@fredkiefer may you update this branch to make it easier to test? it is pre-release. Since branch is protected, i cannot do it. You should have "update" where you have merge.

@gcasa gcasa closed this Feb 17, 2026
@rmottola
Copy link
Copy Markdown
Member

Why was this closed without explanation?

@rmottola
Copy link
Copy Markdown
Member

I think this is still a valid path to pursue, I rebased branch to master and reopen.

@rmottola rmottola reopened this Feb 18, 2026
@gcasa
Copy link
Copy Markdown
Member Author

gcasa commented Mar 12, 2026

Why was this closed without explanation?

Because I wasn't sure if this was the right approach. Are you sure this is the right way to go?

Some of this functionality needs to reside in the backend as well. The issue is that the theme is affecting how printing is processed. It is a mystery to me how macOS handles this because some apps print exactly what is in the view and some don't. So pinning down exactly what is done at the basic level is difficult without us writing our own word processing application which is no small feat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants