Port upstream 0.18.4 (prime + ralph) #8
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09aebe8db6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Receipt is structurally valid - now check the verdict | ||
| if [[ "$receipt_verdict" == "NEEDS_WORK" ]]; then | ||
| # Task marked done but review said NEEDS_WORK - must retry | ||
| echo "ralph: receipt verdict is NEEDS_WORK; resetting task to todo" >> "$iter_log" | ||
| log "task $task_id: receipt verdict=NEEDS_WORK despite done status; resetting" |
There was a problem hiding this comment.
When an impl review receipt contains MAJOR_RETHINK and the task is already marked done, this block only retries on NEEDS_WORK and otherwise proceeds as successful. That contradicts the documented behavior in docs/ralph.md (“Review Loops Until SHIP” and MAJOR_RETHINK blocks progress), so a MAJOR_RETHINK verdict can still advance the run. Consider handling MAJOR_RETHINK the same way as NEEDS_WORK (reset to todo or abort) to prevent accepting fundamentally flawed work.
Useful? React with 👍 / 👎.
Summary\n- port /flow-next:prime skill + scouts + remediation templates\n- add /flow-next:prime command + README updates, bump version/changelog\n- update Ralph receipts enforcement + auto-close unscoped epics\n- document unscoped epic auto-close\n\n## Testing\n- not run (docs/skills/ralph changes only)