fix the issues with github issues backporting to release branch#101
fix the issues with github issues backporting to release branch#101amarts wants to merge 1 commit intogluster:masterfrom
Conversation
amarts
left a comment
amarts
left a comment
There was a problem hiding this comment.
Not sure if this solves the master branch issue.. as the patch checks for non master branch. Is there a flag for knowing there is github ID?
| @@ -23,6 +23,9 @@ BUG=$(git show --name-only --format=email | awk '{IGNORECASE=1} /^BUG:/{print $2 | |||
| if [ -z "${BUG}" -a "${GERRIT_TOPIC}" = "rfc" ]; then | |||
| echo "No BUG id for rfc needed." | |||
There was a problem hiding this comment.
Should we instead add a check here? Patches with rfc should have an issue?
@ShyamsundarR Thoughts?
| if [ -z "${BUG}" -a "${GERRIT_TOPIC}" = "rfc" ]; then | ||
| echo "No BUG id for rfc needed." | ||
| exit 0 | ||
| elif [ -a "${GERRIT_TOPIC#*rfc*}" != "${GERRIT_TOPIC}" -a "${GERRIT_BRANCH}" != "master" ]; then |
There was a problem hiding this comment.
Not sure what we're testing here, because this would be caught above.
There was a problem hiding this comment.
Ack to @nigelbabu's comment.
The intention (as I understand) is to be able to port features to branches without a BUG ID, which is (sort of) disallowed. The exception being between branch creation and first build (typically 2 weeks from branch creation), for noted feature exceptions.
For such noted exceptions, it is better to have a bug created for the backport, as that aids tracking what gets into the release from the point of branching (of course this is when referring to bug tracking alone, and can be achieved when using issue tracking as well, so small proce to pay).
@amarts can you clarify?
3 participants
Not sure if this fixes the master branch rfc branch issue..
@nigelbabu @ShyamsundarR